Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules can finish while descendant modules are still fetching descendants #27073

Closed
jdm opened this issue Jun 24, 2020 · 1 comment
Closed

Modules can finish while descendant modules are still fetching descendants #27073

jdm opened this issue Jun 24, 2020 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Jun 24, 2020

I've tracked down the panic I'm seeing in the webgpu tests which is unrelated to #27061. One case seems to happen when:

encode_selectively.js doesn't finish fetching, but http://web-platform.test:8000/webgpu/common/framework/query/query.js is in the FetchingDescendants state. When stringify_params.js is finished, we recognize that encode_selectively.js is still being fetched and don't finish query.js. However when test_worker.js finishes, we look at the dependencies of wpt.js and decide that since query.js is in the FetchingDescendants state that it's classified as ready. This causes us to finalize wpt.js while encode_selectively.js is still being fetched.

cc @CYBAI

@jdm
Copy link
Member Author

@jdm jdm commented Jun 24, 2020

This was my mistake. I didn't rebase on the recorrect revision.

@jdm jdm closed this Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.