Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderingContext. isContextLost() is undefined #27116

Closed
Rufus31415 opened this issue Jun 29, 2020 · 0 comments
Closed

WebGLRenderingContext. isContextLost() is undefined #27116

Rufus31415 opened this issue Jun 29, 2020 · 0 comments
Labels
A-content/webgl
Projects
HoloLens High priority web compat

Comments

@Rufus31415
Copy link

@Rufus31415 Rufus31415 commented Jun 29, 2020

The method WebGLRenderingContext. isContextLost() doesn't exist in Firefox Reality on Hololens 2.
Every Unity 3D WebGL build use this method.
I am using this workaround to make it work : https://github.com/Rufus31415/Simple-WebXR-Unity/blob/28331fc890e316e13401618a8e0da1e84bad7a39/Assets/SimpleWebXR.jspre#L6
@jdm jdm added the A-content/webgl label Jun 29, 2020
@jdm jdm added this to To do in High priority web compat via automation Jun 29, 2020
@atouchet atouchet added this to To do in HoloLens Jul 3, 2020
@jdm jdm mentioned this issue Jul 3, 2020
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jul 3, 2020
@bors-servo
Auto merge of #27168 - jdm:gl-fake-context-lost, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
689d3c6 
Add stub isContextLost API.

We don't support losing contexts yet, so it's not lying to say that the context is never lost.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27116
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Jul 6, 2020
@bors-servo
Auto merge of #27168 - jdm:gl-fake-context-lost, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b5d782a 
Add stub isContextLost API.

We don't support losing contexts yet, so it's not lying to say that the context is never lost.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27116
- [x] There are tests for these changes
@bors-servo bors-servo closed this in 22a7522 Jul 6, 2020
High priority web compat automation moved this from To do to Done Jul 6, 2020
@atouchet atouchet moved this from To do to Done in HoloLens Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/webgl
Projects
HoloLens
  
Done
High priority web compat
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add stub isContextLost API.
2 participants
@jdm @Rufus31415
You can’t perform that action at this time.