Improve spec compliance of validity check

[gterzian]

This line https://github.com/servo/servo/pull/27100/files#diff-db2031d1f23ecf1a921fc100cfed753dR677

appears incorrect, since the spec only says to fire events on the fields that are invalid, via step 6.1 of https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#statically-validate-the-constraints, which is called into by https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#concept-form-submit

An event is fired on the form element as a whole only as part of the "check validity steps", and those are called into from other places(for example the checkValidity method).

So the implementation of checkValidaty could also be updated to actually fire an event.

see components/script/dom/htmlformelement.rs.

[muodov]

@highfive assign me

[highfive]

Hey @muodov! Thanks for your interest in working on this issue. It's now assigned to you!

[muodov]

Turns out, this is quite a recent change in HTML spec. The invalid event on the <form> element was removed.
So it seems like we can just remove that line in the form submission implementation.

Links:

• HTML issue (PR)
• corresponding WPT change

The validation methods (checkValidity() and reportValidity()) of the <form> element specifically don't mention this event either. The "check validity steps" and "report validity steps" are actually never referred to from the validation section of the <form>, so they only apply to form controls and not the form itself. Those cases are already covered in current implementation.

All in all, it seems like I will just need to remove the line and enable this test :)

[gterzian]

Ok, thanks for looking into this, good research!

The validation methods (checkValidity() and reportValidity()) of the

element specifically don't mention this event either.

Re this, doesn't checkValidity directly call into the check validity steps that fire this event?

[muodov]

@gterzian it took me some time to figure it out, but checkValidity() in "The constraint validation API" has nothing to do with the checkValidity() of the form element.
The constraint validation API is explicitly referred to from form controls specs, for example input element

[gterzian]

Ah ok, so those I was referring to are about form controls, not the form element, as you already had pointed out. Thanks!