Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stdout/stderr logging by default on UWP #27156

Closed
jdm opened this issue Jul 3, 2020 · 0 comments
Closed

Enable stdout/stderr logging by default on UWP #27156

jdm opened this issue Jul 3, 2020 · 0 comments
Labels
Projects

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 3, 2020

We currently disable logging in release builds unless the FirefoxRealityLogStdout environment variable is set. There's no good way to set such a variable on a HoloLens 2 without recompiling the app, which means it's effectively impossible to get logging out of an arbitrary user's build and they have to be provided a custom build instead. This sucks; we should log by default instead so they can always grab it from the app's local files if they encounter a problem. This will give us warn!/error! output and any println/eprintln, such as panic messages.

@jdm jdm added the I-papercut label Jul 3, 2020
@jdm jdm added this to To do in UWP port via automation Jul 3, 2020
bors-servo added a commit that referenced this issue Jul 3, 2020
Enable stdout logging for all UWP builds

Fixes #27156.
@bors-servo bors-servo closed this in 48a76a9 Jul 3, 2020
UWP port automation moved this from To do to Done Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
UWP port
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.