Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many warnings about request stream confirmations when loading pages #27185

Closed
jdm opened this issue Jul 6, 2020 · 1 comment
Closed

Many warnings about request stream confirmations when loading pages #27185

jdm opened this issue Jul 6, 2020 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 6, 2020

For pages that make a bunch of network requests, if you look at the output of RUST_LOG=net::http_loader or RUST_LOG=net, you end up seeing a bunch of WARN - net::http_loader - Failed to receive confirmation request was streamed without error. The fact that everything appears to be working fine suggests that this is not actually a case we need to warn about. @gterzian What can we do to reduce the frequency of this message?

@gterzian
Copy link
Member

@gterzian gterzian commented Jul 7, 2020

Thanks for spotting this, it's actually an omission in the logic, which currently doesn't take into account a non-existent request body.

@bors-servo bors-servo closed this in 1b38197 Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.