Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent timeout in test_hang_monitoring_exit_signal #27191

Closed
jdm opened this issue Jul 7, 2020 · 1 comment
Closed

Intermittent timeout in test_hang_monitoring_exit_signal #27191

jdm opened this issue Jul 7, 2020 · 1 comment
Labels
I-intermittent

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 7, 2020 

     Running target/debug/deps/hang_monitor_tests-cc9feffccc80420b
running 3 tests
test test_hang_monitoring ... ok
test test_hang_monitoring_unregister ... ok
test test_hang_monitoring_exit_signal ... test test_hang_monitoring_exit_signal has been running for over 60 seconds
@jdm jdm added the I-intermittent label Jul 7, 2020
@jdm jdm mentioned this issue Jul 7, 2020
Merged
4 of 4 tasks complete
@gterzian gterzian mentioned this issue Jul 7, 2020
Merged
0 of 5 tasks complete
@gterzian
Copy link
Member

@gterzian gterzian commented Jul 7, 2020

I couldn't reproduce locally(although one time ALL test in the component ended-up hanging), yet I'm hoping the attached PR will ensure it doesn't come back...
bors-servo added a commit that referenced this issue Jul 7, 2020
@bors-servo
Auto merge of #27193 - gterzian:fix_monitor_test_timeout, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
840167e 
improve reliability of hang monitor tests

<!-- Please describe your changes on the following line: -->

FIX #27191

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Jul 7, 2020
@bors-servo
Auto merge of #27193 - gterzian:fix_monitor_test_timeout, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2a95233 
improve reliability of hang monitor tests

<!-- Please describe your changes on the following line: -->

FIX #27191

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo bors-servo closed this in e616284 Jul 7, 2020
@jdm jdm mentioned this issue Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-intermittent
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

improve reliability of hang monitor tests
2 participants
@jdm @gterzian
You can’t perform that action at this time.