Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement navigator.languages #27210

Closed
jdm opened this issue Jul 8, 2020 · 2 comments
Closed

Implement navigator.languages #27210

jdm opened this issue Jul 8, 2020 · 2 comments
Labels
A-content/dom A-embedding
Projects
Hubs support

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 8, 2020

This is used by hubs in places like https://github.com/mozilla/hubs/blob/2c60de07a1cf7ed070f04f440637aa0e3b592e8f/src/utils/i18n.js#L4 and https://github.com/mozilla/hubs/blob/6defae0ef0163a835c551650acdc614bb86e5559/src/storage/media-search-store.js#L81, and breaks the avatar selection panel.
@jdm jdm added the A-content/dom label Jul 8, 2020
@jdm jdm mentioned this issue Jul 8, 2020
Open
@jdm
Copy link
Member Author

@jdm jdm commented Jul 8, 2020

https://html.spec.whatwg.org/multipage/system-state.html#dom-navigator-languages
@jdm
Copy link
Member Author

@jdm jdm commented Jul 8, 2020

This should be a value that is controlled by the embedder as part of initializing the engine, in my opinion. This will allow us to return a meaningful value for non-english locales on the HoloLens 2, for example.
@jdm jdm added the A-embedding label Jul 8, 2020
@jdm jdm added this to To do in Hubs support Jul 8, 2020
This was referenced Jul 14, 2020
Open
Closed
Merged
bors-servo added a commit that referenced this issue Jul 14, 2020
@bors-servo
Auto merge of #27264 - jdm:hubs-stubs, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
03bc624 
Implement Navigator.languages

Fixes #27210.
bors-servo added a commit that referenced this issue Jul 14, 2020
@bors-servo
Auto merge of #27264 - jdm:hubs-stubs, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
418030a 
Implement Navigator.languages

Fixes #27210.
@atouchet atouchet moved this from To do to Done in Hubs support Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom A-embedding
Projects
Hubs support
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Implement Navigator.languages
1 participant
@jdm
You can’t perform that action at this time.