Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTMLFormElement.relList #27252

Closed
jdm opened this issue Jul 13, 2020 · 4 comments
Closed

Implement HTMLFormElement.relList #27252

jdm opened this issue Jul 13, 2020 · 4 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 13, 2020

Spec:

This can be implemented by duplicating the implementation of HTMLAnchorElement as well as adding the missing IDL to components/script/dom/webidls/HTMLFormElement.webidl.

Tests: ./mach test-wpt tests/wpt/web-platform-tests/html/dom/idlharness.https.html
We will need to update tests/wpt/metadata/html/dom/idlharness.https.html.ini to remove the expected failures that will now pass after this change.

@highfive
Copy link

@highfive highfive commented Jul 13, 2020

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in Matrix.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@jdm jdm added this to To do in web-platform-test failures via automation Jul 13, 2020
@avr1254
Copy link
Contributor

@avr1254 avr1254 commented Jul 13, 2020

When I copy the implementation from HTMLAnchorElement, I get an error about self.rel_list being an unknown field. Sorry for the newb question, but should I add a rel_list to the HTMLFromElement struct?

@jdm
Copy link
Member Author

@jdm jdm commented Jul 13, 2020

Yes, add the rel_list to HTMLFormElement like the one in HTMLAnchorElement.

It also looks like we're missing HTMLFormElement.rel as well (https://html.spec.whatwg.org/multipage/forms.html#the-form-element:dom-form-rel). It should be possible to duplicate the implementation of that from HTMLAnchorElement, too, but there are a couple pieces:

@avr1254
Copy link
Contributor

@avr1254 avr1254 commented Jul 13, 2020

Thanks! I'll take a look.

@avr1254 avr1254 mentioned this issue Jul 13, 2020
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Jul 13, 2020
Resolved #27252:   Implemented HTMLFormElement.relList

<!-- Please describe your changes on the following line: -->
Updated the tests to reflect addition of rel and relList for HTMLFormElement, as well as porting those code snippets from HTMLAnchorElement.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #27252  (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Jul 14, 2020
Implemented HTMLFormElement.relList

<!-- Please describe your changes on the following line: -->
Updated the tests to reflect addition of rel and relList for HTMLFormElement, as well as porting those code snippets from HTMLAnchorElement.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #27252  (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
web-platform-test failures automation moved this from To do to Done Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.