Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement HTMLFormElement.relList #27252
Comments
|
Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the If you intend to work on this issue, then add |
|
When I copy the implementation from HTMLAnchorElement, I get an error about self.rel_list being an unknown field. Sorry for the newb question, but should I add a rel_list to the HTMLFromElement struct? |
|
Yes, add the rel_list to HTMLFormElement like the one in HTMLAnchorElement. It also looks like we're missing HTMLFormElement.rel as well (https://html.spec.whatwg.org/multipage/forms.html#the-form-element:dom-form-rel). It should be possible to duplicate the implementation of that from HTMLAnchorElement, too, but there are a couple pieces: |
|
Thanks! I'll take a look. |
Resolved #27252: Implemented HTMLFormElement.relList <!-- Please describe your changes on the following line: --> Updated the tests to reflect addition of rel and relList for HTMLFormElement, as well as porting those code snippets from HTMLAnchorElement. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #27252 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Implemented HTMLFormElement.relList <!-- Please describe your changes on the following line: --> Updated the tests to reflect addition of rel and relList for HTMLFormElement, as well as porting those code snippets from HTMLAnchorElement. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #27252 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Spec:
This can be implemented by duplicating the implementation of HTMLAnchorElement as well as adding the missing IDL to
components/script/dom/webidls/HTMLFormElement.webidl.Tests:
./mach test-wpt tests/wpt/web-platform-tests/html/dom/idlharness.https.htmlWe will need to update
tests/wpt/metadata/html/dom/idlharness.https.html.inito remove the expected failures that will now pass after this change.