Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-random devtools port #27267

Closed
jdm opened this issue Jul 14, 2020 · 4 comments
Closed

Support non-random devtools port #27267

jdm opened this issue Jul 14, 2020 · 4 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 14, 2020

A user reports that the randomized port makes the process of connecting from desktop Firefox more frustrating.

@jdm jdm added this to To do in UWP port via automation Jul 14, 2020
@jdm
Copy link
Member Author

@jdm jdm commented Jul 14, 2020

One possible solution:

  • store the default debugger port as a preference
  • if launching on that port fails, fall back to a random port
  • update the preference when a new port is chosen

Another possible solution:

  • store the debugger port in the UWP app settings
  • when launching the embedding, if there's a port in the app settings pass the --devtools [port] argument

The second sounds easier.

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jul 15, 2020

if launching on that port fails, fall back to a random port

Do you remember why and how often that would happen?

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jul 16, 2020

I'm going for solution 1.

@jdm
Copy link
Member Author

@jdm jdm commented Jul 16, 2020

if launching on that port fails, fall back to a random port

Do you remember why and how often that would happen?

We added the random debugger port in response to a HoloLens OS update stealing port 6000 when we had that hardcoded, which caused FxR to panic during launch.

bors-servo added a commit that referenced this issue Jul 20, 2020
UWP: non random port for devtools, and support for custom UWP prefs

packages-prefs.json is now taken into account for libsimpleservo. Making it possible to have custom pref for the UWP builds, removing some weirdness in the way we handle preferences in the hololens code.

This also adds a new set of preferences to control the devtools server startup state, and make the port choice constant across sessions.

Fix #27267
Fix #22970
UWP port automation moved this from To do to Done Jul 21, 2020
@atouchet atouchet moved this from To do to Done in Mobile developer ergonomics Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
UWP port
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.