Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRWebGLLayer IDL members don't match the specification #27312

Closed
jdm opened this issue Jul 17, 2020 · 0 comments
Closed

XRWebGLLayer IDL members don't match the specification #27312

jdm opened this issue Jul 17, 2020 · 0 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 17, 2020

Spec: https://immersive-web.github.io/webxr/#xrwebgllayer

[SecureContext, Exposed=Window]
interface XRWebGLLayer: XRLayer {
  constructor(XRSession session,
             XRWebGLRenderingContext context,
             optional XRWebGLLayerInit layerInit = {});
  // Attributes
  readonly attribute boolean antialias;
  readonly attribute boolean ignoreDepthValues;

  [SameObject] readonly attribute WebGLFramebuffer? framebuffer;
  readonly attribute unsigned long framebufferWidth;
  readonly attribute unsigned long framebufferHeight;

  // Methods
  XRViewport? getViewport(XRView view);

  // Static Methods
  static double getNativeFramebufferScaleFactor(XRSession session);
};

XRWebGLLayer.webidl:

[SecureContext, Exposed=Window, Pref="dom.webxr.enabled"]
interface XRWebGLLayer {
  [Throws] constructor(XRSession session,
              XRWebGLRenderingContext context,
              optional XRWebGLLayerInit layerInit = {});
  // // Attributes
  readonly attribute XRWebGLRenderingContext context;

  readonly attribute boolean antialias;
  readonly attribute boolean depth;
  readonly attribute boolean stencil;
  readonly attribute boolean alpha;

  readonly attribute WebGLFramebuffer? framebuffer;
  readonly attribute unsigned long framebufferWidth;
  readonly attribute unsigned long framebufferHeight;

  // // Methods
  XRViewport? getViewport(XRView view);
  // void requestViewportScaling(double viewportScaleFactor);

  // // Static Methods
  // static double getNativeFramebufferScaleFactor(XRSession session);
};

This is breaking WPT webxr tests, because they try to set the context property on the layer and it's readonly.

@jdm jdm added this to To do in web-platform-test failures via automation Jul 17, 2020
@jdm jdm self-assigned this Jul 17, 2020
@jdm jdm mentioned this issue Jul 17, 2020
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jul 17, 2020
Update XRWebGLLayer to match specification.

This unbreaks most of the webxr WPT tests.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27312
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Jul 20, 2020
Update XRWebGLLayer to match specification.

This unbreaks most of the webxr WPT tests.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27312
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Jul 20, 2020
Update XRWebGLLayer to match specification.

This unbreaks most of the webxr WPT tests.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27312
- [x] There are tests for these changes
bors-servo added a commit that referenced this issue Jul 21, 2020
Update XRWebGLLayer to match specification.

This unbreaks most of the webxr WPT tests.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27312
- [x] There are tests for these changes
web-platform-test failures automation moved this from To do to Done Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.