Use UTF-8 versions of Compile/Execute for scripts

[jdm]

This will avoid having to encode them as UTF-16 first.

[avr1254]

@highfive:assignme

[avr1254]

@jdm Maybe this would be an interesting challenge to take on!

[avr1254]

@jdm Can you tell me a little more about the issue? I'm assuming you don't mean going through every script and changing the encoding to UTF-8.

[jdm]

@avr1254 In

servo/components/script/dom/htmlscriptelement.rs

Lines 451 to 456 in 5a8023d

	assert!(CompileOffThread(
	*cx,
	options.ptr as *const _,
	&mut transform_u16_to_source_text(&context.utf16_chars) as *mut _,
	Some(off_thread_compilation_callback),
	Box::into_raw(context) as *mut c_void,

and

servo/components/script/dom/globalscope.rs

Lines 2606 to 2610 in 5a8023d

	compiled_script.set(Compile1(
	*cx,
	options.ptr,
	&mut transform_str_to_source_text(text_code),
	));

, we pass UTF-16 bytes to the Compile1 and CompileOffThread spidermonkey APIs. The original bytes we receive from the network are UTF-8 bytes, so we have to encode the bytes as UTF-16 in order to do this. I propose that we call the spidermonkey APIs that accept UTF-8 bytes instead, so we don't have to do the UTF-8->UTF-16 conversion at all.

https://doc.servo.org/mozjs/jsapi/fn.Compile1.html
https://doc.servo.org/mozjs/jsapi/fn.CompileOffThread1.html

[avr1254]

@jdm Isn't the second example already using UTF-8 instead of UTF-16?

[jdm]

You're right!

[jdm]

Aha, here's the other case that I was thinking of:

servo/components/script/script_module.rs

Lines 433 to 437 in c7bdb1b

	rooted!(in(*global.get_cx()) let mut module_script = CompileModule(
	*global.get_cx(),
	compile_options.ptr,
	&mut transform_u16_to_source_text(&module),
	));