Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it so that a webxr panic can be caught by the Servo/UWP panic handler #27344

Closed
paulrouget opened this issue Jul 21, 2020 · 2 comments
Closed
Labels

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jul 21, 2020

The panic described here #27270 is not caught by our panic handler (at least in simpleservo).

Before #186, when device was dropped here https://github.com/servo/webxr/blob/b170a86c081f762d201d3e870febc6e900ad365b/webxr-api/session.rs#L519 a panic would happen, but our catch_any_panic function would not catch it.

We want to catch such panics because we want eventually to be able to inform the user (see #27167).

@jdm jdm added the A-embedding label Jul 21, 2020
@jdm
Copy link
Member

@jdm jdm commented Jul 21, 2020

I think we need to call panic::set_hook like we do for the winit port:

panic::set_hook(Box::new(|info| {

That will catch any panics that occur in threads that do not interact with the C API at all.

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Aug 5, 2020

Fixed by #27438

@paulrouget paulrouget closed this Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.