Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off-thread compiled scripts don't have dynamic import integration #27349

Closed
jdm opened this issue Jul 21, 2020 · 1 comment
Closed

Off-thread compiled scripts don't have dynamic import integration #27349

jdm opened this issue Jul 21, 2020 · 1 comment
Assignees
@jdm
Labels
A-content/script
Milestone
Firefox Reality v1.2

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 21, 2020

When reading through the changes from #26710, I realized that only the scripts that are compiled as part of evaluation get the script private set on them. We should extend this to the off-thread compiled scripts as well.
@jdm jdm mentioned this issue Jul 21, 2020
Open
@jdm
Copy link
Member Author

@jdm jdm commented Jul 21, 2020

I've added a dom.script.asynch preference to #26710 to allow working around this in the short term, rather than delay that PR some more.
@jdm jdm added this to the Firefox Reality v1.2 milestone Jul 22, 2020
@jdm jdm self-assigned this Jul 22, 2020
@jdm jdm mentioned this issue Jul 22, 2020
Merged
bors-servo added a commit that referenced this issue Jul 22, 2020
@bors-servo
Auto merge of #27365 - jdm:offthread-fixes, r=cybai
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
95afc0e 
Fixes for off-thread compilation of scripts

Fixes #27355. Fixes #27349.
bors-servo added a commit that referenced this issue Jul 22, 2020
@bors-servo
Auto merge of #27365 - jdm:offthread-fixes, r=cybai
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6fc2eb1 
Fixes for off-thread compilation of scripts

Fixes #27355. Fixes #27349.
bors-servo added a commit that referenced this issue Jul 22, 2020
@bors-servo
Auto merge of #27365 - jdm:offthread-fixes, r=cybai
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
53710f1 
Fixes for off-thread compilation of scripts

Fixes #27355. Fixes #27349.
bors-servo added a commit that referenced this issue Jul 22, 2020
@bors-servo
Auto merge of #27365 - jdm:offthread-fixes, r=cybai
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7214afe 
Fixes for off-thread compilation of scripts

Fixes #27355. Fixes #27349.
bors-servo added a commit that referenced this issue Jul 22, 2020
@bors-servo
Auto merge of #27365 - jdm:offthread-fixes, r=cybai
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a16130d 
Fixes for off-thread compilation of scripts

Fixes #27355. Fixes #27349.
bors-servo added a commit that referenced this issue Jul 23, 2020
@bors-servo
Auto merge of #27365 - jdm:offthread-fixes, r=cybai
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
63c429b 
Fixes for off-thread compilation of scripts

Fixes #27355. Fixes #27349.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdm jdm

Labels
A-content/script
Projects
None yet
Milestone
Firefox Reality v1.2
Linked pull requests

Successfully merging a pull request may close this issue.

Fixes for off-thread compilation of scripts
1 participant
@jdm
You can’t perform that action at this time.