Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-tidy cuts off whatwg URLs that include apostrophes #27366

Closed
jdm opened this issue Jul 22, 2020 · 1 comment
Closed

test-tidy cuts off whatwg URLs that include apostrophes #27366

jdm opened this issue Jul 22, 2020 · 1 comment
Labels
A-mach I-papercut L-python

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 22, 2020

https://html.spec.whatwg.org/multipage/semantics.html#get-an-element's-target
https://html.spec.whatwg.org/multipage/links.html#get-an-element's-noopener
@jdm
Copy link
Member Author

@jdm jdm commented Jul 22, 2020

servo/python/tidy/servo_tidy/tidy.py

Line 284 in 6a9aac3

match = re.search(br"https://html\.spec\.whatwg\.org/multipage/[\w-]+\.html#([\w\:-]+)", line)
is the regex that needs to be expanded.
@CYBAI CYBAI mentioned this issue Jul 23, 2020
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jul 24, 2020
@bors-servo
Auto merge of #27377 - CYBAI:fix-apostrophes, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
70c59d2 
Handle apostrophes for whatwg URL tidy check

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27366
- [x] These changes do not require tests because it will improve the tidy check for WHATWG URL

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-mach I-papercut L-python
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Handle apostrophes for whatwg URL tidy check
1 participant
@jdm
You can’t perform that action at this time.