Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building servo with existing Rust installation #303

Closed
AndreiBarsan opened this issue Mar 14, 2013 · 4 comments
Closed

Building servo with existing Rust installation #303

AndreiBarsan opened this issue Mar 14, 2013 · 4 comments

Comments

@AndreiBarsan
Copy link

@AndreiBarsan AndreiBarsan commented Mar 14, 2013

Shouldn't building servo also work with a pre-existing Rust installation? Since Rust has to install llvm and itself (which includes lengthy downloads and long compile times) the whole process ends up lasting several hours on my machine, most of which being the Rust toolchain - which is already present on my computer.

Edit:

Note: configure seems to detect my existing installation, but proceeds to clone Rust's github repo anyway

Edit 2:

After some confusing compilation errors, it turns out that it was, in fact, using the version I had installed. Which was a tad old (0.5). I've removed it and compiling the head trunk version of rustc right now.

@jdm
Copy link
Member

@jdm jdm commented Mar 14, 2013

@brson Do you understand how it's set up? Servo's always built with my system rust install without doing anything special.

@brson
Copy link
Contributor

@brson brson commented Mar 14, 2013

The configure script has some old code for detecting or specifying the rust compiler to use (--local-rust-root), but I never bothered to update it when we pulled rust into the tree. As you both suggest it appears to properly detect and use the local rustc, but still builds the in-tree version anyway. It should be pretty easy to have configure set a flag to indicate it's using an out-of-tree Rust and then modify the build rule in Makefile.in.

I don't recommend building with an out-of-tree Rust though because servo typically requires an exact revision of Rust and it's easier to let the build system deal with that. The build times are long though and I have some plans to alleviate them, including modifying the Rust build to reuse the snapshot LLVM and the Servo build to only build Rust up through stage1 (of course, I have had these plans for a while so I'm not sure when they will bear fruit).

@brson
Copy link
Contributor

@brson brson commented Mar 14, 2013

I'll see if I can hack up the build a bit this afternoon to make this work. We'll still need to clone Rust, but not build it.

@brson
Copy link
Contributor

@brson brson commented Mar 15, 2013

OK I changed the configure script so that, by default, it will not look for a local rust installation, but if you do pass --local-rust-root it will use it and not build rust.

@brson brson closed this Mar 15, 2013
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
Fix twitter login crash.

This allows texture allocation to try multiple times, growing or adding texture pages as required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.