Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSVal and ABI #309

Closed
sanxiyn opened this issue Mar 22, 2013 · 1 comment
Closed

JSVal and ABI #309

sanxiyn opened this issue Mar 22, 2013 · 1 comment

Comments

@sanxiyn
Copy link
Contributor

@sanxiyn sanxiyn commented Mar 22, 2013

Currently, JSVal is 64-bit integer in Rust side and 64-bit union in C++ side. This happens to work on x86_64, but can't be expected to work on other architectures, since integer and union can be handled differently by ABI. This happens to be the case on ARM.

Reduced test case at https://gist.github.com/sanxiyn/5219751

@sanxiyn
Copy link
Contributor Author

@sanxiyn sanxiyn commented Mar 28, 2013

Fixed by servo/rust-mozjs#9. Thanks.

@sanxiyn sanxiyn closed this Mar 28, 2013
bors-servo pushed a commit that referenced this issue May 22, 2013
This is a fix for #309 and #308 along with servo/rust-mozjs#18. 
Change JSVal from u64 to {u64}
bors-servo pushed a commit that referenced this issue May 22, 2013
This is a fix for #309 and #308 along with servo/rust-mozjs#18. 
Change JSVal from u64 to {u64}
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.