Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codegen support for callback interfaces with constants #3149

Closed
ChrisParis opened this issue Aug 26, 2014 · 1 comment
Closed

Add codegen support for callback interfaces with constants #3149

ChrisParis opened this issue Aug 26, 2014 · 1 comment

Comments

@ChrisParis
Copy link
Contributor

@ChrisParis ChrisParis commented Aug 26, 2014

This is needed for NodeFilter, which is needed for TreeWalker (#1234).

http://dom.spec.whatwg.org/#interface-nodefilter

bors-servo pushed a commit that referenced this issue Apr 13, 2015
This addresses #3149. The immediate purpose is to support the constants in NodeFilter. The changes mostly follow the current Gecko Codegen.py. The main gist is that the generation of certain code artifacts is now gated by hasInterfaceObject() or hasInterfacePrototypeObject(), rather than by isCallback().
@jdm
Copy link
Member

@jdm jdm commented Jan 6, 2017

We have supported this since #3726.

@jdm jdm closed this Jan 6, 2017
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this issue Jun 12, 2017
… ChrisParis:callback-constants); r=jdm

This addresses servo/servo#3149. The immediate purpose is to support the constants in NodeFilter. The changes mostly follow the current Gecko Codegen.py. The main gist is that the generation of certain code artifacts is now gated by hasInterfaceObject() or hasInterfacePrototypeObject(), rather than by isCallback().

Source-Repo: https://github.com/servo/servo
Source-Revision: 1f9c2f9b34dede8182f45655b03380f8c26f3475
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Sep 30, 2019
… ChrisParis:callback-constants); r=jdm

This addresses servo/servo#3149. The immediate purpose is to support the constants in NodeFilter. The changes mostly follow the current Gecko Codegen.py. The main gist is that the generation of certain code artifacts is now gated by hasInterfaceObject() or hasInterfacePrototypeObject(), rather than by isCallback().

Source-Repo: https://github.com/servo/servo
Source-Revision: 1f9c2f9b34dede8182f45655b03380f8c26f3475

UltraBlame original commit: 52eb9cef707823c685d23357998aa3f773a866a3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
… ChrisParis:callback-constants); r=jdm

This addresses servo/servo#3149. The immediate purpose is to support the constants in NodeFilter. The changes mostly follow the current Gecko Codegen.py. The main gist is that the generation of certain code artifacts is now gated by hasInterfaceObject() or hasInterfacePrototypeObject(), rather than by isCallback().

Source-Repo: https://github.com/servo/servo
Source-Revision: 1f9c2f9b34dede8182f45655b03380f8c26f3475

UltraBlame original commit: 52eb9cef707823c685d23357998aa3f773a866a3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
… ChrisParis:callback-constants); r=jdm

This addresses servo/servo#3149. The immediate purpose is to support the constants in NodeFilter. The changes mostly follow the current Gecko Codegen.py. The main gist is that the generation of certain code artifacts is now gated by hasInterfaceObject() or hasInterfacePrototypeObject(), rather than by isCallback().

Source-Repo: https://github.com/servo/servo
Source-Revision: 1f9c2f9b34dede8182f45655b03380f8c26f3475

UltraBlame original commit: 52eb9cef707823c685d23357998aa3f773a866a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.