Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist rather than blacklist when merging text fragments #3165

Open
SimonSapin opened this issue Aug 27, 2014 · 0 comments
Open

Whitelist rather than blacklist when merging text fragments #3165

SimonSapin opened this issue Aug 27, 2014 · 0 comments

Comments

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Aug 27, 2014

Currently we "merge" text fragments a handful a CSS properties have the same value, i.e. we’re blacklisting differences that should not be merged. This causes issue when the list of properties turns out to be incomplete. See #3163 for example.

Instead, this should probably be a whitelist of properties that are allowed to be different when merging, so that the list being incomplete has a performance cost rather than a correctness cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.