Mac 10.8.2 build failing at /core_foundation.rc

[JamieKnight]

Attempting to build on OSX 10.8.2, build failed with:

/Users/jamie/servo/build/src/rust/x86_64-apple-darwin/stage2/bin/rustc -A default_methods -O  /Users/jamie/servo/src/rust-core-foundation/core_foundation.rc -o librustcorefoundation.dummy
/Users/jamie/servo/src/rust-core-foundation/array.rs:29:42: 29:43 error: obsolete syntax: visibility-qualified trait implementation
/Users/jamie/servo/src/rust-core-foundation/array.rs:29 pub impl AbstractCFTypeRef for CFArrayRef {
                                                                                              ^
note: `pub` or `priv` is meaningless for trait implementations, because the `impl...for...` form defines overloads for methods that already exist; remove the `pub` or `prig`

Full error output here: https://gist.github.com/JamieKnight/5310634#file-gistfile1-txt

I was able to successfully compile rust/master. I attempted to use the compiled rust toolchain already present on my system (using instructions in #303) but this also failed. Not sure how to proceed.

[jinkim]

I've experienced the same problem. I noticed that there were some syntax changes in Rust 0.6 which those errors indicated. So I went and updated to new syntax in my copy where I saw errors.

After the update, I still get error with new assertion ( assert!() ) syntax. It continues to recommend using fail_unless!() instead.

It will compile through if I use fail_unless!() but then get a series errors for inclusion of libc.

use core::libc::c_long; in base.rs for example.

[JamieKnight]

Thanks for the input. Is there a known version of Rust which will compile current servo checkout? How fixable are the errors in libc? I'm trying to get a compile working for my own education and just figuring out how this all hangs together.

[jdm]

When I last updated the in-tree rust checkout, I only built on Fedora. @metajack is updating Servo to build on OS X with a very recent rustc as we speak, so once those changes are finished you should be able to build again.

[metajack]

It should land later today with any luck.

[JamieKnight]

Splendid, will keep an eye out for it. Thanks for the prompt replies.

[metajack]

#322 if you'd like to test it out before it lands.

[JamieKnight]

I have tried a build with the latest merge and have had no luck. It is now report a different error:

/Users/jamie/servo/src/rust-cocoa/base.rs:7:0: 7:3 error: unmatched visibility `pub`

I believe this to be related?

[metajack]

Did the submodules get updated? You might need to rerun configure.

[JamieKnight]

i have rerun configure but the issue persists. Repo is marked as up to date. Any suggestions?

[metajack]

What commit is it at?

[JamieKnight]

rust-cocoa is listed as:
12a7bb3fde3941be1050d46c495fb0fb23aa1880 src/rust-cocoa (remotes/origin/HEAD)

servo repo is most recent (ran git pull before both attempts).

[metajack]

can you post the full error message?

make -C src/rust-cocoa clean all is clean here. I'm on 10.8.3 but I don't think that should matter here. Is it maybe picking up a system rustc?

[JamieKnight]

'make -C src/rust-cocoa clean all' run without error. 'make && make check' is still failing with the following error:

cc -O2 /Users/jamie/servo/src/rust-cocoa/msgsend.c -o msgsend.o -c
ar rcs libmsgsend.a msgsend.o
/Users/jamie/servo/build/src/rust/x86_64-apple-darwin/stage2/bin/rustc -A default_methods -O        /Users/jamie/servo/src/rust-cocoa/cocoa.rc -o libcocoa.dummy
/Users/jamie/servo/src/rust-cocoa/base.rs:7:0: 7:3 error: unmatched visibility `pub`
/Users/jamie/servo/src/rust-cocoa/base.rs:7 pub static nil : id = 0 as id;
                                        ^~~
make[1]: *** [libcocoa.dummy] Error 101
make: *** [/Users/jamie/servo/build/src/rust-cocoa/lib*.dummy] Error 2

I'm not that familiar with make, is there a way to clean all the build options to start from a clean slate? Thanks for the help.

[metajack]

make clean-rust clean should nuke most everything. You can also blow away the build/ dir and rerun configure.

The makefiles still have dependency bugs. We'll be trying to clean that up.

[JamieKnight]

Changes committed last night with skis have resolved the mac build issues.