Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only pass extra link flags on OS X. #3260

Merged
merged 1 commit into from Sep 9, 2014
Merged

Conversation

metajack
Copy link
Contributor

@metajack metajack commented Sep 9, 2014

Fixes #3249

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/2543

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@metajack
Copy link
Contributor Author

metajack commented Sep 9, 2014

@larsberg This was just a mistake when I cargofied. See the original version here:

servo/mk/main.mk

Lines 445 to 447 in db2f642

ifeq ($(CFG_OSTYPE),apple-darwin)
RFLAGS_embedding += -C link-args="-Wl,-U,_tc_new -Wl,-U,_tc_newarray -Wl,-U,_tc_delete -Wl,-U,_tc_deletearray"
endif

@metajack
Copy link
Contributor Author

metajack commented Sep 9, 2014

Wrong @larsberg apologies! @larsbergstrom ^

@larsbergstrom
Copy link
Contributor

Cool, accepted in Critic.

metajack added a commit that referenced this pull request Sep 9, 2014
Only pass extra link flags on OS X.
@metajack metajack merged commit 523270c into servo:master Sep 9, 2014
@metajack metajack deleted the fix-cef-linux branch September 9, 2014 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building CEF fails on linux
3 participants