Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of line breaker errors on yahoo.com #3332

Open
jdm opened this issue Sep 14, 2014 · 3 comments
Open

Lots of line breaker errors on yahoo.com #3332

jdm opened this issue Sep 14, 2014 · 3 comments
Labels
A-layout/inline

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 14, 2014

With #3326 fixed I get this:

tarting program: /Users/jdm/src/master-servo/target/servo ../servo-static-suite/yahoo/Yahoo.html
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
ERROR:layout::inline: LineBreaker: This split case makes no sense!
@jdm jdm added the A-layout/inline label Sep 14, 2014
@jdm
Copy link
Member Author

@jdm jdm commented Sep 15, 2014

Blocks #3289.
@jdm
Copy link
Member Author

@jdm jdm commented Sep 15, 2014

Here's output from the first case:

DEBUG:layout::fragment: split_to_inline_size: splitting text fragment (strlen=6, range=[CharIndex(3) .. CharIndex(4)), avail_inline_size=1px)
DEBUG:layout::fragment: split_to_inline_size: considering slice (offset=CharIndex(3), range=[CharIndex(0) .. CharIndex(1)), remain_inline_size=1px)
DEBUG:layout::fragment: split_to_inline_size: case=skipping trimmable trailing whitespace
ERROR:layout::inline: LineBreaker: This split case makes no sense!
@jdm
Copy link
Member Author

@jdm jdm commented Sep 15, 2014

We appear to be starting a line, with an advance that's greater than the remaining inline size; the glyphs in question are whitespace, and there is no non-whitespace following them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/inline
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@jdm
You can’t perform that action at this time.