Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<link rel="stylesheet"> and <style> with inline stylesheet applied in wrong order #3346

Closed
mbrubeck opened this issue Sep 15, 2014 · 2 comments
Closed

<link rel="stylesheet"> and <style> with inline stylesheet applied in wrong order #3346

mbrubeck opened this issue Sep 15, 2014 · 2 comments
Assignees
@mbrubeck
Labels
A-content/css I-wrong

Comments

@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Sep 15, 2014

The following testcase has a red background, but should have a green background:

<!DOCTYPE html>
<html>
  <head>
    <link rel="stylesheet" href="data:text/css,body{background:red;}">
    <style>body { background: green; }</style>
  </head>
  <body>
  </body>
</html>
@brson brson mentioned this issue Sep 15, 2014
Closed
42 of 56 tasks complete
@jdm
Copy link
Member

@jdm jdm commented Sep 15, 2014

Unsurprisingly, http://mxr.mozilla.org/servo/source/components/script/dom/htmlstyleelement.rs#49 immediately grabs the layout channel and sends the inline contents, while http://mxr.mozilla.org/servo/source/components/script/html/hubbub_html_parser.rs#461 sends a message to the CSS discovery task which waits until all parsing is complete to send a message to the script task to forward the stylesheets to the layout task.
@jdm
Copy link
Member

@jdm jdm commented Sep 15, 2014

The parser code that looks for link elements should probably move to HTMLLinkElement and send a message directly to layout. We don't have any need for the CSS discovery task, as far as I can tell.
@mbrubeck mbrubeck mentioned this issue Sep 15, 2014
Merged
@mbrubeck mbrubeck self-assigned this Sep 15, 2014
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 15, 2014
@mbrubeck
Move link rel=stylesheet fetching to layout task
c679f0d 
Fixes servo#3346.
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 15, 2014
@mbrubeck
Move link rel=stylesheet fetching to layout task
e30c53e 
Fixes servo#3346.
@mbrubeck mbrubeck mentioned this issue Sep 15, 2014
Merged
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 15, 2014
@mbrubeck
Move link rel=stylesheet fetching to layout task
7f3fd4a 
Fixes servo#3346.
@mbrubeck mbrubeck mentioned this issue Sep 16, 2014
Closed
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 16, 2014
@mbrubeck
Move link rel=stylesheet fetching to layout task
1ae3bda 
Fixes servo#3346.
@jdm jdm mentioned this issue Sep 16, 2014
Closed
6 of 6 tasks complete
jkim-julie pushed a commit to jkim-julie/servo that referenced this issue Sep 19, 2014
@mbrubeck Jeongeun Kim
Move link rel=stylesheet fetching to layout task
50bbb49 
Fixes servo#3346.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbrubeck mbrubeck

Labels
A-content/css I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Move link rel=stylesheet fetching to layout task
2 participants
@mbrubeck @jdm
You can’t perform that action at this time.