servo / servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move script loading out of the HTML parser #3356

Closed

mbrubeck opened this issue Sep 16, 2014 · 1 comment

Assignees

Labels

A-content/script C-assigned I-wrong

Contributor

mbrubeck commented Sep 16, 2014

Similar to #1959, but for script. We need to make sure that dynamically-inserted <script> elements are handled correctly, and that inline and remote scripts are loaded synchronously and in the correct order.

mbrubeck added I-wrong A-content/script C-assigned labels

mbrubeck self-assigned this

Member

tetsuharuohzeki commented Sep 17, 2014

#1879 is related.

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Switch to synchronous script loading

0fd1acc

This removes the old code for asyncronously loading scripts during HTML
parsing and then executing them afterward.

Fixes servo#3356.

mbrubeck mentioned this issue

Synchronous script loading during HTML parsing #3721

Merged

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Switch to synchronous script loading

63b943b

This removes the old code for asyncronously loading scripts during HTML
parsing and then executing them afterward.

Fixes servo#3356.

jdm added this to the Dogfooding milestone

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Switch to synchronous script loading

9d5cedb

This removes the old code for asyncronously loading scripts during HTML
parsing and then executing them afterward.

Fixes servo#3356.

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Switch to synchronous script loading

9a42233

This removes the old code for asyncronously loading scripts during HTML
parsing and then executing them afterward.

Fixes servo#3356.

bors-servo pushed a commit that referenced this issue


        auto merge of #3721 : mbrubeck/servo/script-sync, r=Ms2ger

f9887ac

Fixes #3356.  This makes script elements fetch their source synchronously and execute immediately by default.  It also lays some groundwork for future deferred or async script loading.

(Depends on #3716 to fix a content test failure caused by running script during parsing.)

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Switch to synchronous script loading

f8657ef

This removes the old code for asyncronously loading scripts during HTML
parsing and then executing them afterward.

Fixes servo#3356.

mbrubeck added a commit to mbrubeck/servo that referenced this issue


        Switch to synchronous script loading

fe123ad

This removes the old code for asyncronously loading scripts during HTML
parsing and then executing them afterward.

Fixes servo#3356.

bors-servo pushed a commit that referenced this issue


        auto merge of #3721 : mbrubeck/servo/script-sync, r=Ms2ger

272ae0c

Fixes #3356.  This makes script elements fetch their source synchronously and execute immediately by default.  It also lays some groundwork for future deferred or async script loading.

(Depends on #3716 to fix a content test failure caused by running script during parsing.)

bors-servo closed this in #3721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.