Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a stylesheet to the tree should be a synchronous operation with respect to content->layout queries #3363

Open
jdm opened this issue Sep 16, 2014 · 2 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 16, 2014

Before the introduction of LayoutRPC in #3164, this worked fine since messages are synchronous and ordered. However, now introducing a new stylesheet into the tree and immediately querying the layout properties of a node that is affected by the new sheet will yield incorrect information. I guess the code that notifies the layout task about the stylesheet should also cause a layout flush to occur, which should prevent the content->layout queries from executing until the new styles have taken effect.

@metajack
Copy link
Contributor

@metajack metajack commented Sep 16, 2014

When you say flush, do you mean reflow or just invalidation of the layout data? It seems like we should delay reflow until it is needed.

@jdm
Copy link
Member Author

@jdm jdm commented Sep 16, 2014

Well, I really mean reflow because our layout queries all rely on the display list. There's a FIXME about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.