Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding a stylesheet to the tree should be a synchronous operation with respect to content->layout queries #3363
Comments
|
When you say flush, do you mean reflow or just invalidation of the layout data? It seems like we should delay reflow until it is needed. |
|
Well, I really mean reflow because our layout queries all rely on the display list. There's a FIXME about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before the introduction of LayoutRPC in #3164, this worked fine since messages are synchronous and ordered. However, now introducing a new stylesheet into the tree and immediately querying the layout properties of a node that is affected by the new sheet will yield incorrect information. I guess the code that notifies the layout task about the stylesheet should also cause a layout flush to occur, which should prevent the content->layout queries from executing until the new styles have taken effect.