Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page's join_layout can report incorrect results #3370

Open
jdm opened this issue Sep 16, 2014 · 1 comment
Open

Page's join_layout can report incorrect results #3370

jdm opened this issue Sep 16, 2014 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 16, 2014

As described in #3358 (comment), the handle_reflow_complete logic in ScriptTask looks like it properly handles the case of waiting for the last-known script-initiated reflow to complete, but Page's join_layout does not. We should either make join_layout aware of this (by storing a page's last reflow ID in the Page itself and migrating the logic) or force the compositor to send reflow commands via the script task.

@jdm
Copy link
Member Author

@jdm jdm commented Sep 18, 2014

What if we reset the join_layout_port every time content initiates a reflow and send the new sender object with each request? Then join_layout can listen on the newest port, layout can discard any send errors, and compositor-initiated reflow won't cause any spurious notifications to be sent to content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.