Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 12.10 x64 Build failure due to cc linking issue #339

Closed
hgentry opened this issue Apr 7, 2013 · 20 comments
Closed

Ubuntu 12.10 x64 Build failure due to cc linking issue #339

hgentry opened this issue Apr 7, 2013 · 20 comments

Comments

@hgentry
Copy link
Contributor

@hgentry hgentry commented Apr 7, 2013

error: linking with ccfailed with code 1 note: cc arguments: -L/home/hgentry/dev/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -m64 -o libjs-94839cbfe144198-0.1.so libjs.o -L/home/hgentry/dev/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -lcore-c3ca5d77d81b46c1-0.6 -L/home/hgentry/dev/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -lstd-4782a756585a81-0.6 -lpthread -L. -ljs_static -lstdc++ -lz -lrustrt -lrt -lpthread -L/home/hgentry/dev/servo/build/src/mozjs -ljsglue -shared -lrt -ldl -lm -lmorestack -lrustrt -Wl,-rpath,$ORIGIN/../rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -Wl,-rpath,/home/hgentry/dev/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -Wl,-rpath,/usr/local/lib/rustc/x86_64-unknown-linux-gnu/lib note: /usr/bin/ld: ./libjsglue.a(jsglue.o): relocation R_X86_64_32S against.rodata' can not be used when making a shared object; recompile with -fPIC`

@jdm
Copy link
Member

@jdm jdm commented Apr 7, 2013

Does the problem go away if you change https://github.com/mozilla-servo/rust-mozjs/blob/master/Makefile.in#L7 to use += instead of ?= and then run configure again before building?

@metajack
Copy link
Contributor

@metajack metajack commented Apr 7, 2013

This is a regression from @pcwalton's recent fix. The line should be += not ?=.

@klutzy
Copy link
Contributor

@klutzy klutzy commented Apr 7, 2013

I experienced same linking failure; after += fix it's ok for me. (using Debian sid x64)

@cyniu
Copy link

@cyniu cyniu commented Apr 7, 2013

same linking failure; after the same fix as klutzy, it allows me to build. (using fedora 17 x64). But when I tested the about page, I got "SkFontHost::OpenStream failed opening 1" with a blank blue window opened. the make check process told me that there were unresolved names like Cell and unwrap..

still no luck to display any text in the opened window. and when I tried to test other pages, I got a memory leak message as follows:

./servo ../src/test/test_close.html

leaked memory in rust main loop (6 objects)
servo: /home/alanox/rustservo/servo-master/servo/src/rust/src/rt/memory_region.cpp:189: memory_region::~memory_region(): Assertion `false' failed.
Aborted (core dumped)

@hgentry
Copy link
Contributor Author

@hgentry hgentry commented Apr 7, 2013

When I re-run configure with that fix, it changes the += back to a ?=.

@astrieanna
Copy link
Contributor

@astrieanna astrieanna commented Apr 7, 2013

@hgentry I had the same problem; you have to run configure with the option --disable-manage-submodules to prevent it from reverting any changes you make to submodules.

@hgentry
Copy link
Contributor Author

@hgentry hgentry commented Apr 7, 2013

Thanks! That made it stop changing it. I'll update when the build finishes/fails.

Edit: Build now finishes! I wind up with this when I give it about-mozilla.html: funky blue output I got the same make check results as @cyniu :

home/hgentry/dev/servo/build/src/rust-wapcaplet /home/hgentry/dev/servo/src/rust-css/css.rc -o css-test --test
/home/hgentry/dev/servo/src/rust-css/test.rs:7:4: 7:20 error: unresolved name
/home/hgentry/dev/servo/src/rust-css/test.rs:7 use std::cell::Cell;
                                                   ^~~~~~~~~~~~~~~~
/home/hgentry/dev/servo/src/rust-css/test.rs:7:4: 7:20 error: failed to resolve import: std::cell::Cell
/home/hgentry/dev/servo/src/rust-css/test.rs:7 use std::cell::Cell;
                                                   ^~~~~~~~~~~~~~~~
/home/hgentry/dev/servo/src/rust-css/color.rs:194:8: 194:23 error: unresolved name
/home/hgentry/dev/servo/src/rust-css/color.rs:194     use option::unwrap;
                                                          ^~~~~~~~~~~~~~~
/home/hgentry/dev/servo/src/rust-css/color.rs:194:8: 194:23 error: failed to resolve import: option::unwrap
/home/hgentry/dev/servo/src/rust-css/color.rs:194     use option::unwrap;
                                                          ^~~~~~~~~~~~~~~
error: failed to resolve imports
error: aborting due to 5 previous errors

It looks like the problems with make check are covered in #340 . I'll see what I can find about the doom blue.

@metajack
Copy link
Contributor

@metajack metajack commented Apr 7, 2013

The weird font results are probably the result of you missing Times New Roman. Can you install that and try again? Currently servo is not falling back on fonts correctly.

@hgentry
Copy link
Contributor Author

@hgentry hgentry commented Apr 7, 2013

That certainly fixed the font. Woo!

Is the blue to be expected? In gecko it is red...

installed Times New Roman

@ricklyman
Copy link

@ricklyman ricklyman commented Apr 8, 2013

re: Debian GNU/Linux 6.0
after += fix:
(/var/servo/build/src/rust-mozjs/Makefile)
(/var/servo/src/rust-mozjs/Makefile.in)

../configure --disable-manage-submodules

same linking failure:

/var/servo/build# make && make check
make[1]: Entering directory /var/servo/build/src/rust-mozjs' /var/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/bin/rustc -A default_methods -O -L /var/servo/build/src/mozjs /var/servo/src/rust-mozjs/js.rc -o libjs.dummy error: linking withccfailed with code 1 note: cc arguments: -L/var/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -m64 -o libjs-94839cbfe144198-0.1.so libjs.o -L/var/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -lcore-c3ca5d77d81b46c1-0.6 -L/var/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -lstd-4782a756585a81-0.6 -lpthread -L. -ljs_static -lstdc++ -lz -lrustrt -lrt -lpthread -L/var/servo/build/src/mozjs -ljsglue -shared -lrt -ldl -lm -lmorestack -lrustrt -Wl,-rpath,$ORIGIN/../rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -Wl,-rpath,/var/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -Wl,-rpath,/usr/local/lib/rustc/x86_64-unknown-linux-gnu/lib note: /usr/bin/ld: ./libjsglue.a(jsglue.o): relocation R_X86_64_32S against.rodata' can not be used when making a shared object; recompile with -fPIC
./libjsglue.a: could not read symbols: Bad value
collect2: ld returned 1 exit status

error: aborting due to previous error
make[1]: *** [libjs.dummy] Error 101
make[1]: Leaving directory `/var/servo/build/src/rust-mozjs'
make: ** [/var/servo/build/src/rust-mozjs/lib.dummy] Error 2

@xspager
Copy link

@xspager xspager commented Apr 8, 2013

For me the suggested change to Makefile.in fixed the build on Ubuntu 12.10

Screenshot from 2013-04-08 18:11:58

Also about-mozilla.html background is blue.

@hgentry
Copy link
Contributor Author

@hgentry hgentry commented Apr 8, 2013

@xspager You'll have to install the Microsoft fonts. The package name is ttf-mscorefonts-installer.

@hgentry
Copy link
Contributor Author

@hgentry hgentry commented Apr 9, 2013

I'm new to open source contribution, but since it's a one-character fix, would it be a faux pas for me to go ahead and submit a pull request with a fix for this?

@jdm
Copy link
Member

@jdm jdm commented Apr 9, 2013

I already fixed the problem, but haven't had a change to update the servo submodule to the latest rust-mozjs revision. Please feel free to submit a pull request doing that!

@metajack
Copy link
Contributor

@metajack metajack commented Apr 9, 2013

@hgentry For future reference, such a pull request would have been gladly accepted if @jdm hadn't already done it :)

jdm added a commit that referenced this issue Apr 9, 2013
update submodule rust-mozjs according to #339
@jdm
Copy link
Member

@jdm jdm commented Apr 9, 2013

Should be fixed now.

@jdm jdm closed this Apr 9, 2013
@ricklyman
Copy link

@ricklyman ricklyman commented Apr 9, 2013

@hgentry re: The package name is ttf-mscorefonts-installer

Do you know the package name for Debian?

Package ttf-mscorefonts-installer is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

@hgentry
Copy link
Contributor Author

@hgentry hgentry commented Apr 9, 2013

I don't, but according to Debian it is available here: http://packages.debian.org/sid/ttf-mscorefonts-installer

@sanxiyn
Copy link
Contributor

@sanxiyn sanxiyn commented Apr 10, 2013

@ricklyman, you need contrib in your sources.list.

@ricklyman
Copy link

@ricklyman ricklyman commented Apr 10, 2013

@sanxiyn: Thanks, It lives...

On Wed, Apr 10, 2013 at 2:24 AM, Seo Sanghyeon notifications@github.comwrote:

@ricklyman https://github.com/ricklyman, you need contrib in your
sources.list.


Reply to this email directly or view it on GitHubhttps://github.com//issues/339#issuecomment-16157532
.

ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
Removed vendor prefixes in user timing tests
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
Switch 3d transform shaders to be features, rather than separate shaders.

This doesn't change any existing functionality, but makes adding 3d transform
support for other primitives much simpler and more maintainable.

Also clean up the renderer code for each primitive type into a generic method.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/339)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.