Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Node::get_bounding_content_box, Node::get_content_boxes, Document::hit_test, and Document::get_node_under_mouse #356
Labels
Comments
|
There are a lot of places making calls to Page::query_layout that have to do more work than they should. We can add nice APIs for these common queries and make the code much more pleasant to read. |
jdm
changed the title
bors-servo
pushed a commit
that referenced
this issue
Apr 24, 2014
|
Fixed by #2210. |
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this issue
Sep 7, 2014
…around Work around the fact that idlharness.js doesn't support DOMTimeStamp yet.
glennw
pushed a commit
to glennw/servo
that referenced
this issue
Jan 16, 2017
Update euclid to 0.10 and offscreen_gl_context to 0.4 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/356) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Dec 23, 2019
Remove obsolete HasInstance behavior per heycam/webidl #356 This turns one WPT test from fail to pass and it leaves Servo with a little less platform object special-case code to worry about. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25039 <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this issue
Dec 23, 2019
Remove obsolete HasInstance behavior per heycam/webidl #356 This turns one WPT test from fail to pass and it leaves Servo with a little less platform object special-case code to worry about. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25039 <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this issue
Dec 23, 2019
Remove obsolete HasInstance behavior per heycam/webidl #356 This turns one WPT test from fail to pass and it leaves Servo with a little less platform object special-case code to worry about. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25039 <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently I'm manually munging the results of Content::query_layout from DOM code. This is really ugly, and we should put a sensible API over top of this to hide the query/result details.