Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement partial dictionary codegen support #3588

Open
jdm opened this issue Oct 6, 2014 · 2 comments
Open

Implement partial dictionary codegen support #3588

jdm opened this issue Oct 6, 2014 · 2 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 6, 2014

#3585 adds a commented out partial dictionary definition to KeyboardEvent.webidl. I doubt that this is a particularly big deal to port from Gecko's CodeGen.py (possibly requiring porting changes from parser/WebIDL.py as well), but I don't have much to go on. This could be a fun task for someone who'd like to learn more about the DOM binding code generation.

@ChrisParis
Copy link
Contributor

@ChrisParis ChrisParis commented Oct 19, 2014

It looks like Gecko's WebIDL parser and Codegen also do not support partial dictionaries. Dictionaries defined in parts in the spec are combined into single definitions. For example, http://mxr.mozilla.org/mozilla-central/source/dom/webidl/KeyboardEvent.webidl.

@jdm jdm removed the E-less easy label Feb 27, 2015
@jdm
Copy link
Member Author

@jdm jdm commented Feb 27, 2015

In that case that's definitely not a "less easy" task to implement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.