Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root ClientRect wrappers stored in ClientRectList #363

Closed
jdm opened this issue Apr 12, 2013 · 2 comments
Closed

Root ClientRect wrappers stored in ClientRectList #363

jdm opened this issue Apr 12, 2013 · 2 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 12, 2013

The client rects are not attached to the DOM tree in any way, nor are they sitting on the stack and thus visible to the conservative stack svanner, so they're sitting ducks for being GCed at any time. A trace hook would be nicer from a conceptual standpoint, but explicit rooting seems like it would be much easier to integrate since it wouldn't have to interact with the autogenerated bindings.

@bzbarsky
Copy link
Contributor

@bzbarsky bzbarsky commented Apr 12, 2013

Note that client rects can exist outside a ClientRectList, in case that matters.

@jdm
Copy link
Member Author

@jdm jdm commented Apr 1, 2014

We have trace hooks generated by the compiler that do this now. Oh joyous day!

@jdm jdm closed this Apr 1, 2014
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
Revert "Merge pull request servo#358 from ayg/submission/ayg-use-webidl2"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.