Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent failure in link_style_dynamic_addition reftest #3636

Closed
mbrubeck opened this issue Oct 10, 2014 · 2 comments
Closed

Intermittent failure in link_style_dynamic_addition reftest #3636

mbrubeck opened this issue Oct 10, 2014 · 2 comments

Comments

@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Oct 10, 2014

tests/ref/link_style_dynamic_addition.html (added by #3432) fails frequently on Linux. The failure seems to be a timing-sensitive race, but I've been able to reproduce the failure both in and out of the reftest harness, especially with #3563 applied. The page is rendered white, presumably because it is rendered before the stylesheet is loaded. We need to make sure we re-layout and repaint after all scripts have run (and before writing any PNG output).

mbrubeck added a commit to mbrubeck/servo that referenced this issue Oct 10, 2014
sgmenda pushed a commit to sgmenda/servo that referenced this issue Aug 3, 2015
…linear_gradients_smoke_a.html linear_gradients_smoke_ref.html 189 == linebreak_inline_span_a.html linebreak_inline_span_b.html 190 flaky_cpu == linebreak_simple_a.html linebreak_simple_b.html 191 # Fails intermittently (servo#3636) 192 # == link_style_dynamic_addition.html link_style_dynamic_addition_ref.html 193 == link_style_order.html link_style_order_ref.html 194 == list_style_image_sizing_a.html list_style_image_sizing_ref.html 195 == list_style_position_a.html list_style_position_ref.html 196 != list_style_type_a.html list_style_type_ref.html 197 == many_brs_a.html many_brs_ref.html 198 == margin_a.html margin_b.html 199 == margins_inside_floats_a.html margins_inside_floats_ref.html 200 == max_width_float_simple_a.html max_width_float_simple_b.html 201 == max_width_simple_a.html max_width_simple_b.html 202 == min_max_height_a.html min_max_height_b.html 203 == min_width_float_simple_a.html min_width_float_simple_b.html 204 == min_width_simple_a.html min_width_simple_b.html 205 == minimum_line_height_a.html minimum_line_height_b.html 206 == mix_blend_mode_a.html mix_blend_mode_ref.html 207 == multiple_css_class_a.html multiple_css_class_b.html 208 == negative_margin_uncle_a.html negative_margin_uncle_b.html 209 == negative_margins_a.html negative_margins_b.html 210 == no-image.html no-image-ref.html 211 == no_image_background_a.html no_image_background_ref.html 212 == noscript.html noscript_ref.html 213 != noteq_attr_exists_selector.html attr_exists_selector_ref.html 214 == nth_child_pseudo_a.html nth_child_pseudo_b.html 215 == nth_last_child_pseudo_a.html nth_last_child_pseudo_b.html 216 == nth_last_of_type_pseudo_a.html nth_last_of_type_pseudo_b.html 217 == nth_of_type_pseudo_a.html nth_of_type_pseudo_b.html 218 == object_element_a.html object_element_b.html 219 == ol_japanese_iroha_a.html ol_japanese_iroha_ref.html 220 != ol_japanese_iroha_bullet_styles.html ol_japanese_iroha_ref.html 221 == ol_simple_a.html ol_simple_ref.html 222 == only_child_pseudo_a.html only_child_pseudo_b.html 223 == only_of_type_pseudo_a.html only_of_type_pseudo_b.html 224 == opacity_simple_a.html opacity_simple_ref.html 225 == opacity_stacking_context_a.html opacity_stacking_context_ref.html 226 == outline_offset_a.html outline_offset_ref.html 227 == outlines_simple_a.html outlines_simple_ref.html 228 == outlines_wrap_a.html outlines_wrap_ref.html 229 == outset.html outset_ref.html 230 != outset_blackborder.html blackborder_ref.html 231 # Should be == with expected failure. See servo#2797 232 != overconstrained_block.html overconstrained_block_ref.html 233 == overflow_auto.html overflow_simple_b.html 234 == overflow_scroll.html overflow_simple_b.html 235 == overflow_simple_a.html overflow_simple_b.html 236 == overflow_wrap_a.html overflow_wrap_ref.html 237 == overflow_xy_a.html overflow_xy_ref.html 238 == per_glyph_font_fallback_a.html per_glyph_font_fallback_ref.html 239 == percent_height.html percent_height_ref.html 240 == percentage_height_float_a.html percentage_height_float_ref.html 241 == percentage_height_root.html percentage_height_root_ref.html 242 == percentage_width_inline_block_a.html percentage_width_inline_block_ref.html 243 == png_rgba_colorspace_a.html png_rgba_colorspace_b.html 244 == position_abs_cb_with_non_cb_kid_a.html position_abs_cb_with_non_cb_kid_b.html 245 == position_abs_height_width_a.html position_abs_height_width_b.html 246 == position_abs_left_a.html position_abs_left_b.html 247 == position_abs_margin_top_percentage_a.html position_abs_margin_top_percentage_b.html 248 == position_abs_nested_a.html position_abs_nested_b.html 249 == position_abs_pseudo_a.html position_abs_pseudo_b.html 250 == position_abs_replaced_simple_a.html position_abs_replaced_simple_b.html 251 == position_abs_static_y_a.html position_abs_static_y_b.html 252 == position_abs_width_percentage_a.html position_abs_width_percentage_b.html 253 # commented out because multiple layers don't work with reftests --pcwalton 254 # == position_fixed_a.html position_fixed_b.html 255 == position_fixed_background_color_a.html position_fixed_background_color_b.html 256 == position_fixed_overflow_a.html position_fixed_overflow_b.html 257 # == position_fixed_simple_a.html position_fixed_simple
@nox
Copy link
Member

@nox nox commented Jan 2, 2016

@mbrubeck Was that fixed?

@nox
Copy link
Member

@nox nox commented Jan 3, 2016

This was ported to a WPT test and isn't disabled anymore.

@nox nox closed this Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.