Support application/form-data and text/plain #3649

Manishearth · 2014-10-11T05:47:15Z

For form data encoding we might be able to share code with FormData (and be able to enable FormData support in XHR)

We can probably ignore files for now.


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support - Support for the other two enctypes (#3649) Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` (#3648) - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support - Support for the other two enctypes (#3649) Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` (#3648) - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support - Support for the other two enctypes (#3649) Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` (#3648) - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support - Support for the other two enctypes (#3649) Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` (#3648) - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)


        auto merge of #3642 : Manishearth/servo/form-submit, r=jdm

This is missing a lot of parts, so it doesn't really make any real-world form submission work yet. It provides a skeleton on which the missing bits can be filled in. What works: - `<input>` elements except for `type=file` - GET/POST methods - URLencoded `enctype`s (default) - Submission via `<form>.submit()` only Stuff that needs to be done for most simple real-world cases to work: - [Working text input](#3585) - Click handlers for `<submit>` - Possibly `<textarea>` support - Support for the other two enctypes (#3649) Todo: - Correctly implement [planned navigation](https://html.spec.whatwg.org/multipage/forms.html#planned-navigation) using `TrustedFormAddress` (#3648) - [Correctly implement form owners.](#3553) Requires html5ever and some discussion of the spec. - `<input type=file>` support - Image submit support - Browsing contexts/targets - Support for non-`<input>` controls - Validation (?) - Dirname (?)


        auto merge of #5219 : doublec/servo/view_source_protocol_and_plain_te…

…xt, r=jdm Implements view-source protocol by having a view-source handler, and modifying the content type to be text/plain if that is used. Implements text/plain handling. This allows view-source content to display as plain text. Example usage: ./mach run http://cd.pn/x.txt ./mach run view-source:http://tinyvid.tv/ This fixes issue #4181. Issue #3649 includes "support text/plain" so this possibly fixes some of that issue as well.


        auto merge of #5219 : doublec/servo/view_source_protocol_and_plain_te…

…xt, r=jdm Implements view-source protocol by having a view-source handler, and modifying the content type to be text/plain if that is used. Implements text/plain handling. This allows view-source content to display as plain text. Example usage: ./mach run http://cd.pn/x.txt ./mach run view-source:http://tinyvid.tv/ This fixes issue #4181. Issue #3649 includes "support text/plain" so this possibly fixes some of that issue as well.


        auto merge of #5219 : doublec/servo/view_source_protocol_and_plain_te…

…xt, r=jdm Implements view-source protocol by having a view-source handler, and modifying the content type to be text/plain if that is used. Implements text/plain handling. This allows view-source content to display as plain text. Example usage: ./mach run http://cd.pn/x.txt ./mach run view-source:http://tinyvid.tv/ This fixes issue #4181. Issue #3649 includes "support text/plain" so this possibly fixes some of that issue as well.

KiChjang · 2016-05-01T04:27:43Z

The only thing left to do now is to support text/plain.


        Auto merge of #10953 - KiChjang:text-plain-encoding, r=jdm

Implement text/plain form encoding Fixes #3649.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10953)


        Auto merge of #10953 - KiChjang:text-plain-encoding, r=jdm

Implement text/plain form encoding Fixes #3649.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10953)


        Auto merge of #10953 - KiChjang:text-plain-encoding, r=jdm

Implement text/plain form encoding Fixes #3649.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10953)

Manishearth mentioned this issue Oct 11, 2014

Implement extremely basic form submission #3642

Merged

This was referenced Mar 13, 2015

Add view-source protocol #4181

Closed

view-source protocol and text/plain handling #5219

Closed

jdm added the A-content/dom label Mar 15, 2015

KiChjang mentioned this issue Nov 28, 2015

Correctly implement planned navigation #3648

Closed

KiChjang mentioned this issue Dec 23, 2015

Add support for multipart/form-data #7553

Closed

KiChjang self-assigned this May 1, 2016

KiChjang removed their assignment May 1, 2016

KiChjang added the E-less easy label May 1, 2016

KiChjang self-assigned this May 1, 2016

KiChjang added the C-assigned label May 1, 2016

KiChjang mentioned this issue May 1, 2016

Implement text/plain form encoding #10953

Merged

bors-servo closed this in #10953 May 12, 2016

servo / servo

Support application/form-data and text/plain #3649

Support application/form-data and text/plain #3649

Manishearth commented Oct 11, 2014

KiChjang commented May 1, 2016

servo / servo

Join GitHub today

Support application/form-data and text/plain #3649

Support application/form-data and text/plain #3649

Comments

Manishearth commented Oct 11, 2014

KiChjang commented May 1, 2016