Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using AppendChild in the HTML parser #3701

Closed
kmcallister opened this issue Oct 16, 2014 · 3 comments
Closed

Stop using AppendChild in the HTML parser #3701

kmcallister opened this issue Oct 16, 2014 · 3 comments

Comments

@kmcallister
Copy link
Contributor

@kmcallister kmcallister commented Oct 16, 2014

It's likely that we can skip much of the complex logic used to handle insertions by arbitrary JavaScript code. Also we need to merge adjacent text nodes during parsing to be spec-compliant.

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Oct 16, 2014

Not sure that's worth it; I like the peace of mind that using the DOM entry point gives me.

@kmcallister
Copy link
Contributor Author

@kmcallister kmcallister commented Oct 16, 2014

I'm not sure it's worth it either, but I'd like to do the experiment. See also #1269.

@nox
Copy link
Member

@nox nox commented Sep 30, 2017

We now merge properly and following the spec wording as long as it's not a perf issue in real world is nice. Closing.

@nox nox closed this Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.