Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low hanging fruit. #375

Closed
JamieKnight opened this issue Apr 17, 2013 · 10 comments
Closed

Low hanging fruit. #375

JamieKnight opened this issue Apr 17, 2013 · 10 comments
Labels

Comments

@JamieKnight
Copy link
Contributor

@JamieKnight JamieKnight commented Apr 17, 2013

It would be good to have a list of tasks which are somewhat newbie friendly. I want to help, but i'm not quite sure where to start.

I saw this mentioned in the meeting notes (here: https://github.com/mozilla/servo/wiki/Meeting-2013-04-15) but the suggested work there (padding, borders etc) feels like a high starting point.

I'm at first looking for trivial stuff:

  • Converting tabs to spaces etc
  • Renaming stuff
  • Writing docs

Any suggestions? I have done a tiny amount of rust code, but happy to bash on till i get something to work.

Cheers,

Jamie + Lion

@metajack
Copy link
Contributor

@metajack metajack commented Apr 17, 2013

In terms of docs, updating the installation instructions would be good. Several people have noted that the instructions are missing a few needed components on Linux.

Another easier coding project would be to finish excising all mention of cairo from various places. I still found stuff left over (variables named cairo_x that should be freetype_x etc).

Some legacy Rust syntax is still around that needs updating. For example. ++ in front of function parameters in declarations (it can just be removed). Or fixing the build warnings in rust code, which mostly amounts to removing unused imports.

I'll keep adding as I think of more.

@JamieKnight
Copy link
Contributor Author

@JamieKnight JamieKnight commented Apr 17, 2013

Thanks @metajack will go have a poke around and see what i can do.

@metajack
Copy link
Contributor

@metajack metajack commented Apr 17, 2013

Bug triage and reproduction is always helpful too.

@burg
Copy link

@burg burg commented Apr 17, 2013

There are many, many small tasks within layout but they are fairly context-deep. :-( I need to triage some of my old bugs.

@JamieKnight
Copy link
Contributor Author

@JamieKnight JamieKnight commented Apr 17, 2013

Thanks for the responses. I'm building servo now. I have made some small changes to font.rs (renaming cairo stuff), once it's built i will verify nothing has blown up and open a pull request. Planning on keeping first whirl simple.

Is there some documentation on how to build little parts of the project and running the related tests? If i understand make correctly, if i make && make check from /build it will only recompile files which have changed.

@metajack
Copy link
Contributor

@metajack metajack commented Apr 17, 2013

To build a specific subcomponent you can do make -C src/foo.

There are also lots of make targets that get defined like make rust-azure and make clean-rust-azure etc. Documenting those would be nice :)

@JamieKnight
Copy link
Contributor Author

@JamieKnight JamieKnight commented Apr 17, 2013

Will put together a list of which submodules have their own make files.

Is don't see a makefile in servo-gfx where i have been prodding, is this because all the servo stuff gets done in one go? I have been using make servo to test, i'm running make check servo now.

Next candidate seems to be unused imports in rust-layers/test.rs: its throwing a lot of warnings.

@jdm
Copy link
Member

@jdm jdm commented Apr 17, 2013

Note that some imports are platform-dependent and show up as unused on other platforms.

@metajack
Copy link
Contributor

@metajack metajack commented May 16, 2013

The contents of this bug should be a wiki page, or should turn into individual bugs labeled E-easy.

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Aug 29, 2013

I think this can be closed now that there is a bunch of issues marked E-easy. (I also think this is the right way to maintain that list of easy tasks.)

@SimonSapin SimonSapin closed this Aug 29, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
moving helper .js files for timeout tests to resources/ folder
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
webgl: Add vertexAttribPointer and disableVertexAttribArray support

I have a corresponding series to servo using these to reduce webgl-conformance failures.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/375)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.