Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow layout performance in hello_rust #3786

Closed
steveklabnik opened this issue Oct 23, 2014 · 6 comments
Closed

Slow layout performance in hello_rust #3786

steveklabnik opened this issue Oct 23, 2014 · 6 comments

Comments

@steveklabnik
Copy link
Contributor

@steveklabnik steveklabnik commented Oct 23, 2014

Sorry for the terrible title, I'm not sure what a good one is here.

Basically, https://steveklabnik.github.io/hello_rust/ loaded in firefox works pretty awesome. the same page loaded in servo (after applying #3585 ) is very, very, very slow. With only a few slides, it's fast, but it gets slower the more you add. It feels O(n^2) but i haven't done any formal benchmarking.

It also happens when you build with --release.

@jdm
Copy link
Member

@jdm jdm commented Oct 23, 2014

Profiling under instruments shows me that more than 70% of time is spent in layout workers.

cc @pcwalton

@mbrubeck mbrubeck changed the title Performance issue? Slow layout performance in hello_rust Oct 23, 2014
@kmcallister
Copy link
Contributor

@kmcallister kmcallister commented Oct 31, 2014

Interesting. I have a 34-slide deck and performance is adequate in a release build Servo on Linux. I'm building 0e95d6d which was the head of @jdm's PR last I fetched it.

@kmcallister
Copy link
Contributor

@kmcallister kmcallister commented Oct 31, 2014

Perf on https://steveklabnik.github.io/hello_rust/ is also fine in my build.

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Oct 31, 2014

We have incremental reflow now as well as several font-related bugs fixed so that might have fixes it.

@kmcallister
Copy link
Contributor

@kmcallister kmcallister commented Oct 31, 2014

But I'm on this old PR branch, I didn't rebase recently...

@nox
Copy link
Member

@nox nox commented Sep 30, 2017

That doesn't seem to be true anymore.

@nox nox closed this Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.