Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unrecognized command line option `-Wno-c++11-extensions` on mac #380

Closed
brson opened this issue Apr 18, 2013 · 7 comments
Closed

unrecognized command line option `-Wno-c++11-extensions` on mac #380

brson opened this issue Apr 18, 2013 · 7 comments
Assignees

Comments

@brson
Copy link
Contributor

@brson brson commented Apr 18, 2013

Building rust-azure I see error: unrecognized command line option "-Wno-c++11-extensions". My compiler is

i686-apple-darwin10-llvm-g++-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) ( LLVM build 2336.1.00).

Running on OS X 10.6.8.

@metajack
Copy link
Contributor

@metajack metajack commented Apr 19, 2013

mozjs also has such a switch, but it is autodetected by configure. We'll need to configurize (lightly!) rust-azure to do similar detection to fix this.

@brson
Copy link
Contributor Author

@brson brson commented Apr 19, 2013

I'll do that tomorrow.

@ghost ghost assigned brson Apr 19, 2013
@brson
Copy link
Contributor Author

@brson brson commented Apr 23, 2013

After making changes to the makefiles to get past this error, the azure build fails with mfbt (and Gecko) require at least gcc 4.4 to build, and I have 4.2.

@metajack
Copy link
Contributor

@metajack metajack commented Apr 23, 2013

I have gcc 4.2.1, so I'm not sure how you hit this. Where does that error come from? Did you grab configure from upstream or something?

@brson
Copy link
Contributor Author

@brson brson commented Apr 23, 2013

The error comes from Compiler.h

@metajack
Copy link
Contributor

@metajack metajack commented Apr 28, 2013

Since this code is liberated from Gecko, I think we can remove this check.

I'm not sure what part of mfbt requires gcc 4.4, or even what mfbt is. We do have a few files in the mfbt directory though.

@burg
Copy link

@burg burg commented Apr 28, 2013

IIRC, mfbt is shared code, similar to NSPR but much newer and with less ambition.

  • sent from a mobile device -

On Apr 28, 2013, at 11:28, Jack Moffitt notifications@github.com wrote:

Since this code is liberated from Gecko, I think we can remove this check.

I'm not sure what part of mfbt requires gcc 4.4, or even what mfbt is. We do have a few files in the mfbt directory though.


Reply to this email directly or view it on GitHub.

@yichoi yichoi closed this May 2, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
Added tests for some event dispatching edge cases; r=zcorpan
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
Pack blend/composite primitives with floats.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/380)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.