Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure is not checking for libpango #381

Closed
mehlis opened this issue Apr 19, 2013 · 5 comments
Closed

configure is not checking for libpango #381

mehlis opened this issue Apr 19, 2013 · 5 comments

Comments

@mehlis
Copy link

@mehlis mehlis commented Apr 19, 2013

error: linking with cc failed with code 1
note: cc arguments: -L/home/c/git/public/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -m64 -o libharfbuzz-94839cbfe144198-0.1.so libharfbuzz.o -L/home/c/git/public/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -lcore-c3ca5d77d81b46c1-0.6 -L/home/c/git/public/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -lstd-4782a756585a81-0.6 -L. -lharfbuzz -lpango-1.0 -lglib-2.0 -lstdc++ -lrustrt -lrt -lpthread -shared -lrt -ldl -lm -lmorestack -lrustrt -Wl,-rpath,$ORIGIN/../rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -Wl,-rpath,/home/c/git/public/servo/build/src/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib -Wl,-rpath,/usr/local/lib/rustc/x86_64-unknown-linux-gnu/lib
note: /usr/bin/ld: cannot find -lpango-1.0

@burg
Copy link

@burg burg commented Apr 20, 2013

Can you copy the actual invocation into the issue as well?

@aydinkim
Copy link

@aydinkim aydinkim commented Apr 22, 2013

At linkhack.rs in rust-harfbuzz, there is a linking code with libpango for g++ linking time.
As I checked, we don't need that linking code.
I can eliminate that code and send pull request.

@mehlis
Copy link
Author

@mehlis mehlis commented Apr 22, 2013

i just tried to build it, it was not working because of the missing libpango.
i installed the package and now it's building :)

the configure script had no waning for the missing libpango...so the build failed

@aydinkim
Copy link

@aydinkim aydinkim commented Apr 23, 2013

Currently, as I checked, Servo doesn't use the pango anymore. it was related to cairo. The cairo has been eliminated couple of weeks ago.

@metajack
Copy link
Contributor

@metajack metajack commented Apr 23, 2013

This should be fixed now.

@metajack metajack closed this Apr 23, 2013
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
Switch primitives to make use of the caching available in prepare_render.

This is a slight performance win, but is mostly to make it easier to switch UBOs to SoA style. When this is done, these changes allow a much greater performance improvement (since primitives that hit multiple tiles are added only once).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/381)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.