Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to checkout servo code on Windows host #3911

Closed
leonardinius opened this issue Nov 6, 2014 · 5 comments
Closed

Unable to checkout servo code on Windows host #3911

leonardinius opened this issue Nov 6, 2014 · 5 comments
Labels

Comments

@leonardinius
Copy link

@leonardinius leonardinius commented Nov 6, 2014

$ git clone https://github.com/servo/servo.git mozilla-servo
Cloning into 'mozilla-servo'...
remote: Counting objects: 64130, done.
remote: Compressing objects: 100% (264/264), done.
remote: Total 64130 (delta 143), reused 28 (delta 11)
Receiving objects: 100% (64130/64130), 29.65 MiB | 277.00 KiB/s, done.
Resolving deltas: 100% (42564/42564), done.
Checking connectivity... done.
error: unable to create file tests/ref/hello_a?foo#bar.html (Invalid argument)
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

The problem appears to be with tests/ref/hello_a?foo#bar.html file

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Nov 6, 2014

Note that we don't support running or building on Windows at all.

@leonardinius
Copy link
Author

@leonardinius leonardinius commented Nov 6, 2014

English is not my mother tongue, hopefully I will be able to express my thought clear enough.

Note that we don't support running or building on Windows at all.

@Ms2ger I know ;)

  • ? However I suppose you will (at some point of time)
  • I suppose you might consider / consider Windows based developer contributions (e.g. documentation, whatever ..)

As per current moment - the stuff like this breaks simple attempts to contribute, read code etc ...

It's not a issue for me, since I was going to fetch the code just of sake of fetching, reading through it, etc .. Most likely I will just fork repo, remove the offending file and use my fork from that point forward.

I understand the issue like this is some kind of 'white noise' at this stage of the project.
The real reason I raised it - I just wanted to make a point there is already something in codebase which breaks simple and easy access to code from Windows and it might become even bigger problem in the future (e.g. test infra dependence on filenames like that etc ...).

Please feel free to close this issue, as it is nothing more than just 'raise an awareness flag' type of issue.

@jdm
Copy link
Member

@jdm jdm commented Nov 6, 2014

I guess we'll need to find some other way to test #3340 :(
http://mxr.mozilla.org/servo/source/tests/ref/basic.list#5

@adamncasey
Copy link
Contributor

@adamncasey adamncasey commented Jan 28, 2016

I think this can be closed, it clones successfully on Windows even without MSYS. The filename issues are presumably all fixed.

@jdm
Copy link
Member

@jdm jdm commented Jan 28, 2016

Yay!

@jdm jdm closed this Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.