Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache response types in XHR #3919

Closed
Manishearth opened this issue Nov 6, 2014 · 7 comments
Closed

Cache response types in XHR #3919

Manishearth opened this issue Nov 6, 2014 · 7 comments
Assignees
@KiChjang
Labels
A-content/dom C-assigned I-wrong

Comments

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 6, 2014

See https://xhr.spec.whatwg.org/#response-json-object -- the parsed responses should be cached once calculated.

Should make /XMLHttpRequest/response-json.htm pass.
@Manishearth Manishearth self-assigned this Nov 6, 2014
@Manishearth Manishearth mentioned this issue Nov 6, 2014
Merged
@Ms2ger Ms2ger removed the C-assigned label Feb 21, 2015
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Feb 21, 2015

Blocks #2525.
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jan 26, 2016

I'll see if I can fix this up.
@KiChjang KiChjang added the C-assigned label Jan 26, 2016
@KiChjang KiChjang self-assigned this Jan 26, 2016
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Feb 1, 2016

Blocks #9489.
@KiChjang KiChjang mentioned this issue Feb 12, 2016
Merged
bors-servo added a commit that referenced this issue Feb 15, 2016
@bors-servo
Auto merge of #9621 - KiChjang:xhr-response-json, r=Ms2ger
94d6ca2 
Cache XHR JSON responses

Fixes #3919.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9621)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Feb 15, 2016
@bors-servo
Auto merge of #9621 - KiChjang:xhr-response-json, r=Ms2ger
Loading status checks…
5ee5ce0 
Cache XHR JSON responses

Fixes #3919.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9621)
<!-- Reviewable:end -->
@Ms2ger Ms2ger reopened this Feb 15, 2016
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Feb 15, 2016

@Ms2ger So I suppose that we still have ArrayBuffer responses to cache?
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Feb 15, 2016

I need to double check we got them all
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Dec 9, 2016

@Ms2ger What's left to do here?
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Dec 9, 2016

ArrayBuffer is not implemented, and the rest is cached.
@Ms2ger Ms2ger closed this Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KiChjang KiChjang

Labels
A-content/dom C-assigned I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@Ms2ger @Manishearth @KiChjang
You can’t perform that action at this time.