Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iframes should load about:blank by default #3924

Closed
jdm opened this issue Nov 7, 2014 · 3 comments
Closed

iframes should load about:blank by default #3924

jdm opened this issue Nov 7, 2014 · 3 comments
Labels
A-content/dom I-wrong

Comments

@jdm
Copy link
Member

@jdm jdm commented Nov 7, 2014

https://html.spec.whatwg.org/multipage/embedded-content.html#process-the-iframe-attributes

In particular, this load must cause contentWindow to be non-null. https://hsivonen.fi/about-blank/ is good reading.
@neojski neojski mentioned this issue Nov 7, 2014
Open
This was referenced Aug 18, 2015
Closed
Closed
Closed
Closed
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Aug 18, 2015

jdm@e8aa1e1
master...Ms2ger:empty-iframe-load
@jdm
Copy link
Member Author

@jdm jdm commented Aug 23, 2015

Blocks #5236.
@jdm jdm mentioned this issue Nov 19, 2015
Closed
bors-servo added a commit that referenced this issue Nov 19, 2015
@bors-servo
Auto merge of #8600 - jdm:loadexperiments, r=<try>
a88898e 
Support synchronous about:blank loads

@Ms2ger, I would appreciate your thoughts on this design. It leverages the existing synchronous API support for the network load (the same way that sync XHR works), and introduces a one-off channel for the constellation's frame creation notification message when necessary.

Resolves #3924.
bors-servo added a commit that referenced this issue Nov 19, 2015
@bors-servo
Auto merge of #8600 - jdm:loadexperiments, r=<try>
03b3a95 
Support synchronous about:blank loads

@Ms2ger, I would appreciate your thoughts on this design. It leverages the existing synchronous API support for the network load (the same way that sync XHR works), and introduces a one-off channel for the constellation's frame creation notification message when necessary.

Resolves #3924.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8600)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Sep 14, 2016
@bors-servo
Auto merge of #8600 - jdm:loadexperiments, r=<try>
Loading status checks…
d3c7da1 
Support synchronous about:blank loads

@Ms2ger, I would appreciate your thoughts on this design. It leverages the existing synchronous API support for the network load (the same way that sync XHR works), and introduces a one-off channel for the constellation's frame creation notification message when necessary.

Resolves #3924.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8600)
<!-- Reviewable:end -->
@jdm jdm mentioned this issue Sep 16, 2016
Closed
@jdm
Copy link
Member Author

@jdm jdm commented Dec 14, 2016

We fixed this in #13996.
@jdm jdm closed this Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @Ms2ger
You can’t perform that action at this time.