Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add css support list in tree #3954

Closed
metajack opened this issue Nov 11, 2014 · 3 comments
Closed

add css support list in tree #3954

metajack opened this issue Nov 11, 2014 · 3 comments

Comments

@metajack
Copy link
Contributor

@metajack metajack commented Nov 11, 2014

We should move the data for https://docs.google.com/spreadsheets/d/1CxLS8w8GwK-2euVErrqpUUb76PiZa6w5h5EnGsL9KFs/edit?usp=sharing to an in tree list, and then generate a nice html display like we do doc generation. This will allow us to keep it up to date as new PRs land.

Additionally, element.style things only exist for things we actually support, but it would be nice not to maintain the list of supported features in two places. We should come up with a way to generate one from the other.

@metajack
Copy link
Contributor Author

@metajack metajack commented Nov 11, 2014

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Nov 11, 2014

At the moment the Mako template can only generate one (.rs) file because that was easier, but can be extended to generate more stuff automatically and we definitely should not duplicate things like the list of supported properties.

I’ve been looking at Cargo’s new build script system anyway (rust-lang/cargo#824, rust-lang/rust#18849, rust-lang/rust#18810 (comment)) to make the Mako template use it and avoid having generated files in the source tree.

In both cases though (doc of supported properties and element.style), the caveat from @pcwalton’s email apply:

This only indicates whether Servo has any support at all for each CSS property. It does not test whether the implementation of the property is bug-free in Servo, whether all of the features of the property (e.g. multiple backgrounds) are supported, or whether the property is implemented in a performant manner.

@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented May 20, 2016

Fixed by #10208.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.