Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove force_relayout calls from HTMLInputElement attribute handler methods #3959

Closed
jdm opened this issue Nov 11, 2014 · 8 comments
Closed

Remove force_relayout calls from HTMLInputElement attribute handler methods #3959

jdm opened this issue Nov 11, 2014 · 8 comments
Labels
A-content/dom C-assigned E-easy

Comments

@jdm
Copy link
Member

@jdm jdm commented Nov 11, 2014

Given that Element::after_set_attr and Element::before_remove_attr call Element::notify_content_changed, I believe that force_layout is extraneous and should be removed.
@jdm jdm changed the title Remove force_layout calls from HTMLInputElement attribute handler methods Remove force_relayout calls from HTMLInputElement attribute handler methods Nov 11, 2014
@ienzam
Copy link
Contributor

@ienzam ienzam commented Dec 1, 2014

Hi, I will like to start with this one.

Do I need to
a) remove all the reference only?
b) remove all the references and delete the force_relayout function too?
@mttr
Copy link
Contributor

@mttr mttr commented Dec 1, 2014

This use of force_relayout is actually needed to refresh the display of the text input. All of the other uses are redundant, as far as I can tell at least.
@jdm
Copy link
Member Author

@jdm jdm commented Dec 1, 2014

If there's only one reference left after removing the other ones, then we can just inline it and remove the function.
@mttr
Copy link
Contributor

@mttr mttr commented Dec 1, 2014

For what it's worth, I'm also using the method in PR #4133 so that input text boxes get updated after being reset or changed by javascript.
@ienzam ienzam mentioned this issue Dec 2, 2014
Closed
@ienzam
Copy link
Contributor

@ienzam ienzam commented Dec 3, 2014

Hi,
Sorry I missed some issues and wnat to remove this patch.
I will add the patch again, sorry for the trouble.
@jdm
Copy link
Member Author

@jdm jdm commented Mar 11, 2015

@ienzam Still planning to work on this?
@ienzam
Copy link
Contributor

@ienzam ienzam commented Mar 11, 2015

I am extremely sorry for not following up.
I will send a patch in one/two days.
@ienzam ienzam mentioned this issue Mar 11, 2015
Merged
@ienzam
Copy link
Contributor

@ienzam ienzam commented Mar 11, 2015

Hi jdm, created the patch again.
Sorry for the delay.
bors-servo pushed a commit that referenced this issue Mar 11, 2015
bors-servo
auto merge of #5198 : ienzam/servo/force_relayout_cleanup, r=jdm
Loading status checks…
7b6e314 
This is a cleanup for issue #3959 

Do I need to inline force_relayout?
@jdm jdm added the C-assigned label Mar 11, 2015
@jdm jdm closed this Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @ienzam @mttr
You can’t perform that action at this time.