Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make l20n work in Servo #4159

Closed
zbraniecki opened this issue Dec 1, 2014 · 14 comments
Closed

Make l20n work in Servo #4159

zbraniecki opened this issue Dec 1, 2014 · 14 comments

Comments

@zbraniecki
Copy link

@zbraniecki zbraniecki commented Dec 1, 2014

Servo is very close to have everything needed to support l20n.js in its current form. Let's track what's missing.

@zbraniecki
Copy link
Author

@zbraniecki zbraniecki commented Dec 1, 2014

Depends on #1980 and #2974

@zbraniecki
Copy link
Author

@zbraniecki zbraniecki commented Dec 1, 2014

CC @stasm

@zbraniecki
Copy link
Author

@zbraniecki zbraniecki commented Feb 19, 2015

Depends on #4282

@jdm
Copy link
Member

@jdm jdm commented Feb 19, 2015

These dependencies seem to belie the original assertion of "very close" :)

@zbraniecki
Copy link
Author

@zbraniecki zbraniecki commented Feb 19, 2015

We didn't use Promise at the time when I tested and dataset was about to land. Now we have MutationObserver and Promise missing - it's a bit further, but both depend on the same issue (microtasks) which is progressing.

@zbraniecki
Copy link
Author

@zbraniecki zbraniecki commented Apr 13, 2016

Also, pending #4283

@zbraniecki
Copy link
Author

@zbraniecki zbraniecki commented Oct 28, 2016

As of today, l20n is only blocked by #1980

@fabricedesre
Copy link
Contributor

@fabricedesre fabricedesre commented May 19, 2018

@zbraniecki Now that #20740 has landed I think we are in a much better shape. Do you have a test suite we can run on Servo?

@zbraniecki
Copy link
Author

@zbraniecki zbraniecki commented May 19, 2018

www.projectfluent.org uses Fluent (which is the new incarnation of L20n). If it doesn't work, I'll have to dig deeper to find what breaks.
You can also try a simple example - https://github.com/projectfluent/fluent.js/blob/master/fluent-web/examples/simple.html

@zbraniecki
Copy link
Author

@zbraniecki zbraniecki commented May 19, 2018

Ok, the website seems to work! The exampl doesn't because servo uses old SpiderMonkey(?) - async functions don't work, const in for loops etc. I think once we get an update of SM we should be good! :)

@zbraniecki
Copy link
Author

@zbraniecki zbraniecki commented May 22, 2018

I believe that means we're only blocked by #20585 now.

@fabricedesre
Copy link
Contributor

@fabricedesre fabricedesre commented May 22, 2018

Right now we can run in "compat" mode, but yes we need #20585 to get all the goodies.

@atouchet
Copy link
Contributor

@atouchet atouchet commented Aug 21, 2018

#20585 has now been done.

@zbraniecki
Copy link
Author

@zbraniecki zbraniecki commented Aug 21, 2018

Yay! Confirmed that latest servo works with FluentDOM and FluentWeb! It properly displays https://www.projectfluent.org as well :)

@zbraniecki zbraniecki closed this Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.