Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ports/cef: Implement accelerated compositing for the CEF port. #4193

Merged
merged 1 commit into from Dec 10, 2014

Conversation

pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Dec 3, 2014

@glennw, is it possible to rebase your stuff on top of this? Sorry for the mess.

r? @metajack

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/3354

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm jdm added the S-awaiting-review There is new code that needs to be reviewed. label Dec 3, 2014
@glennw
Copy link
Member

glennw commented Dec 3, 2014

@pcwalton No worries, I'll rebase on this once it lands - the Linux changes are minor.

@metajack
Copy link
Contributor

metajack commented Dec 5, 2014

@pcwalton Comments in critic. This will also need a rebase.

@metajack metajack added S-needs-rebase There are merge conflict errors. S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 5, 2014
@pcwalton
Copy link
Contributor Author

pcwalton commented Dec 7, 2014

re-r? @metajack (just one issue left which is resolved in my other PR, so if it's OK I'd like to address it there and land this)

@pcwalton pcwalton added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. S-needs-rebase There are merge conflict errors. labels Dec 7, 2014
@jdm jdm added the S-needs-rebase There are merge conflict errors. label Dec 8, 2014
@pcwalton
Copy link
Contributor Author

pcwalton commented Dec 8, 2014

re-r? @metajack

@pcwalton pcwalton removed the S-needs-rebase There are merge conflict errors. label Dec 8, 2014
@metajack
Copy link
Contributor

metajack commented Dec 9, 2014

@pcwalton Finished re-r. 3 remaining issues, all small.

@metajack metajack added S-awaiting-review There is new code that needs to be reviewed. S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 9, 2014
@metajack
Copy link
Contributor

metajack commented Dec 9, 2014

Ready for squash.

@metajack metajack added S-needs-squash Some (or all) of the commits in the PR should be combined. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Dec 9, 2014
@metajack metajack added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-needs-squash Some (or all) of the commits in the PR should be combined. labels Dec 9, 2014
bors-servo pushed a commit that referenced this pull request Dec 9, 2014
@glennw, is it possible to rebase your stuff on top of this? Sorry for the mess.

r? @metajack
@metajack
Copy link
Contributor

metajack commented Dec 9, 2014

@pcwalton: build failed

window.rs:10:89: 10:108 error: unresolved import `compositing::windowing::FinishedWindowEvent`. There is no `FinishedWindowEvent` in `compositing::windowing`
window.rs:10 use compositing::windowing::{ScrollWindowEvent, ZoomWindowEvent, NavigationWindowEvent, FinishedWindowEvent};
                                                                                                     ^~~~~~~~~~~~~~~~~~~
error: aborting due to previous error
Could not compile `glut_app`.

@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 9, 2014
bors-servo pushed a commit that referenced this pull request Dec 10, 2014
@glennw, is it possible to rebase your stuff on top of this? Sorry for the mess.

r? @metajack
bors-servo pushed a commit that referenced this pull request Dec 10, 2014
@glennw, is it possible to rebase your stuff on top of this? Sorry for the mess.

r? @metajack
@bors-servo bors-servo closed this Dec 10, 2014
@bors-servo bors-servo merged commit 8b2aadc into servo:master Dec 10, 2014
@emilio emilio mentioned this pull request Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-code-changes Changes have not yet been made that were requested by a reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants