Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bindings are regenerated more often than necessary #421

Closed
jdm opened this issue May 8, 2013 · 5 comments
Closed

Bindings are regenerated more often than necessary #421

jdm opened this issue May 8, 2013 · 5 comments
Labels
A-content/bindings I-perf-slow

Comments

@jdm
Copy link
Member

@jdm jdm commented May 8, 2013

After I make a change to CodegenRust.py, I find that subsequent invocations of make tends to trigger rebuilds of the bindings, regardless as to whether I have actually modified CodegenRust again.
@burg
Copy link

@burg burg commented May 30, 2013

It seems like it always regenerates on every build.
@caitp
Copy link

@caitp caitp commented May 30, 2013

is it weird that I'm not having this happen? it seems to be just partial build/relink crates that I've touched.
@jdm
Copy link
Member Author

@jdm jdm commented Jul 8, 2013

I tracked down the cause. regenerateFileIfNecessary in CodegenRust.py looks at the current input and desired output of a given file and avoids rewriting it if there's no difference. However, all generated bindings files declare make dependencies on CodegenRust.py, so when you modify CodegenRust.py the dependency graph shows that all the generated bindings need to be recreated. Since they don't, however, this continues perpetually.
@jdm
Copy link
Member Author

@jdm jdm commented Jul 8, 2013

https://bugzilla.mozilla.org/show_bug.cgi?id=861587 is relevant, since Gecko seemingly solved this.
@metajack
Copy link
Contributor

@metajack metajack commented Jul 10, 2013

This is mostly fixed by #574 I think.
@jdm jdm closed this Aug 27, 2013
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
@gw3583
Implement filter: brightness.
5e5b3ae 
Fixes servo#421.
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
@bors-servo
Auto merge of servo#422 - glennw:brightness, r=pcwalton
dfa4246 
Implement filter: brightness.

Fixes servo#421.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/422)
<!-- Reviewable:end -->
@jdm jdm mentioned this issue Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings I-perf-slow
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @metajack @burg @caitp
You can’t perform that action at this time.