Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement URLUtils #4250

Closed
Zirak opened this issue Dec 5, 2014 · 4 comments
Closed

Implement URLUtils #4250

Zirak opened this issue Dec 5, 2014 · 4 comments
Labels
A-content/dom

Comments

@Zirak
Copy link
Contributor

@Zirak Zirak commented Dec 5, 2014

Spec: https://url.spec.whatwg.org/#urlutils-and-urlutilsreadonly-members

It's an interface used in several places, for instance HTMLAnchorElement and Location.

I'd like to try and take it on myself.
@jdm
Copy link
Member

@jdm jdm commented Dec 5, 2014

Go for it!
@jdm jdm added the A-content/dom label Dec 5, 2014
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Dec 5, 2014

The gory details of parsing are already implemented in rust-url, although the API is not exposed yet to Rust users because it’s kinda ugly. So what remains to do is the DOM bindings and plugging things together.
@nox nox mentioned this issue Aug 15, 2015
Merged
bors-servo pushed a commit that referenced this issue Aug 30, 2015
bors-servo
Auto merge of #7228 - nox:urlutils-setters, r=jdm
Loading status checks…
347e9b6 
Implement setters in URLUtils

This fixes #6145 and takes care of most of #4250.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7228)
<!-- Reviewable:end -->
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Oct 13, 2016

Is there anything else actionable here? I think this interface is gone whatwg/url#62
@jdm
Copy link
Member

@jdm jdm commented Oct 13, 2016

Yeah, we now have HTMLHyperlinkUtils instead, iirc. Nothing to be done here.
@jdm jdm closed this Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @SimonSapin @frewsxcv @Zirak
You can’t perform that action at this time.