Implement Promise in Servo #4282

tetsuharuohzeki · 2014-12-08T16:12:17Z

We need ES6 Promise implementation to support some APIs and dogfooding. However, SpiderMonkey has not been implemented it yet because there are a web standards problems with how the JS virtual machine's event loop should interact with the event loop of the web browser itself.

Therefore, we need to implement Promise in Servo until SM gets Promise in itself.

See also: https://github.com/servo/servo/wiki/Mozlandia-JS#promises

farodin91 · 2015-07-29T13:31:43Z

I like to do this.

jdm · 2015-07-29T13:38:23Z

At least #4283 needs to be completed first, and we probably need to run any proposed design by the more-experienced Gecko developers first to make sure we don't do anything silly.

farodin91 · 2015-07-29T13:40:54Z

Okay

Ms2ger · 2015-10-06T15:02:35Z

Something happened: https://bugzilla.mozilla.org/show_bug.cgi?id=1185106

larsbergstrom · 2016-01-26T01:13:49Z

@tschneidereit is planning to work on this in Q1.

tschneidereit · 2016-01-26T10:13:01Z

Indeed. I am working on it right now in that I'm implementing Promises in SpiderMonkey. Once that's landed, I'll start working on the Servo integration.

larsbergstrom · 2016-05-12T13:27:37Z

It looks like @nox landed the SpiderMonkey update with your work!

@tschneidereit do you know what the timeline is for promises in Servo?

The WebBluetooth folks (cc @loki04) were wondering. Thanks!

nox · 2016-05-12T13:28:56Z

IIRC they can't enable SM promises yet in Gecko itself because of win32 issues, but @tschneidereit knows all there is to know about them so let's wait for his reply.

jdm · 2016-06-21T14:06:04Z

10:01 <till> jdm: we can prototype it right now. For actually enabling it we *need* bug 1272887 and bug 1280789, and *want* half of the patches pending review in bug 911216
10:01 <firebot> https://bugzil.la/1272887 — FIXED, sphink — win32 crash during GC when using PersistentRooted<GCVector>
10:01 <firebot> https://bugzil.la/1280789 — FIXED — unbreak mingw builds after 1272887
10:01 <firebot> https://bugzil.la/911216 — ASSIGNED, till — Implement promises in the JavaScript engine
10:01 <jdm> till: ok, so an SM upgrade right now won't even get us to the point we'll need to be at?
10:01 <till> jdm: in other words, a smup beginning next week :)

I'm going to start prototyping codegen integration.

jdm · 2016-06-21T23:37:23Z

master...jdm:promise-binding is what I've got so far. The rooting story for the JS promise values is not great yet, but it's probably no worse than how we deal with EventTarget and other callbacks?

jdm · 2016-06-28T13:39:35Z

Blocks #11894.


        Auto merge of #12830 - jdm:promises, r=<try>

@dati91

Implement promise bindings This implements support for using Promises in WebIDL, executing promise callbacks in batches (equivalent to running all enqueued jobs from a setTimeout(0)), and attaching native callbacks to promise objects. This is the combined work of myself, @dati91, and @mmatyas based on the following prior work in Gecko: * Codegen.py * Promise.webidl * Promise.cpp/Promise.h * PromiseNativeHandler.h This does not implement microtasks per #4283. This allows us to make progress on testing code that requires the use of Promises right now; the microtasks work is more complicated, but also largely orthogonal to implement. Requires servo/mozjs#89, servo/rust-mozjs#287, and servo/rust-mozjs#294. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #4282 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12830)


        Auto merge of #12830 - jdm:promises, r=<try>

@dati91

Implement promise bindings This implements support for using Promises in WebIDL, executing promise callbacks in batches (equivalent to running all enqueued jobs from a setTimeout(0)), and attaching native callbacks to promise objects. This is the combined work of myself, @dati91, and @mmatyas based on the following prior work in Gecko: * Codegen.py * Promise.webidl * Promise.cpp/Promise.h * PromiseNativeHandler.h This does not implement microtasks per #4283. This allows us to make progress on testing code that requires the use of Promises right now; the microtasks work is more complicated, but also largely orthogonal to implement. Requires servo/mozjs#89, servo/rust-mozjs#287, and servo/rust-mozjs#294. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #4282 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12830)


        Auto merge of #12830 - jdm:promises, r=<try>

@dati91

Implement promise bindings This implements support for using Promises in WebIDL, executing promise callbacks in batches (equivalent to running all enqueued jobs from a setTimeout(0)), and attaching native callbacks to promise objects. This is the combined work of myself, @dati91, and @mmatyas based on the following prior work in Gecko: * Codegen.py * Promise.webidl * Promise.cpp/Promise.h * PromiseNativeHandler.h This does not implement microtasks per #4283. This allows us to make progress on testing code that requires the use of Promises right now; the microtasks work is more complicated, but also largely orthogonal to implement. Requires servo/mozjs#89, servo/rust-mozjs#287, and servo/rust-mozjs#294. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #4282 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12830)


        Auto merge of #12830 - jdm:promises, r=<try>

@dati91

Implement promise bindings This implements support for using Promises in WebIDL, executing promise callbacks in batches (equivalent to running all enqueued jobs from a setTimeout(0)), and attaching native callbacks to promise objects. This is the combined work of myself, @dati91, and @mmatyas based on the following prior work in Gecko: * Codegen.py * Promise.webidl * Promise.cpp/Promise.h * PromiseNativeHandler.h This does not implement microtasks per #4283. This allows us to make progress on testing code that requires the use of Promises right now; the microtasks work is more complicated, but also largely orthogonal to implement. Requires servo/mozjs#89, servo/rust-mozjs#287, and servo/rust-mozjs#294. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #4282 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12830)


        Auto merge of #12830 - jdm:promises, r=<try>

@dati91

Implement promise bindings This implements support for using Promises in WebIDL, executing promise callbacks in batches (equivalent to running all enqueued jobs from a setTimeout(0)), and attaching native callbacks to promise objects. This is the combined work of myself, @dati91, and @mmatyas based on the following prior work in Gecko: * Codegen.py * Promise.webidl * Promise.cpp/Promise.h * PromiseNativeHandler.h This does not implement microtasks per #4283. This allows us to make progress on testing code that requires the use of Promises right now; the microtasks work is more complicated, but also largely orthogonal to implement. Requires servo/mozjs#89, servo/rust-mozjs#287, and servo/rust-mozjs#294. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #4282 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12830)


        Auto merge of #12830 - jdm:promises, r=Ms2ger

@dati91

Implement promise bindings This implements support for using Promises in WebIDL, executing promise callbacks in batches (equivalent to running all enqueued jobs from a setTimeout(0)), and attaching native callbacks to promise objects. This is the combined work of myself, @dati91, and @mmatyas based on the following prior work in Gecko: * Codegen.py * Promise.webidl * Promise.cpp/Promise.h * PromiseNativeHandler.h This does not implement microtasks per #4283. This allows us to make progress on testing code that requires the use of Promises right now; the microtasks work is more complicated, but also largely orthogonal to implement. Requires servo/mozjs#89, servo/rust-mozjs#287, and servo/rust-mozjs#294. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #4282 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12830)

tetsuharuohzeki added A-content/dom A-content/bindings labels Dec 8, 2014

tetsuharuohzeki changed the title ~~Implement Promsie in Servo~~ Implement Promise in Servo Dec 8, 2014

tetsuharuohzeki mentioned this issue Dec 8, 2014

Implement microtasks #4283

Closed

zbraniecki mentioned this issue Feb 19, 2015

Make l20n work in Servo #4159

Closed

dati91 mentioned this issue Jan 21, 2016

Implement WebBluetooth in Servo #9392

Closed

jdm mentioned this issue Aug 12, 2016

Implement promise bindings #12830

Merged

4 of 4 tasks complete

jeenalee mentioned this issue Sep 1, 2016

Implement JS fetch API #11894

Closed

bors-servo closed this in #12830 Sep 22, 2016

servo / servo

Implement Promise in Servo #4282

Implement Promise in Servo #4282

tetsuharuohzeki commented Dec 8, 2014

farodin91 commented Jul 29, 2015

jdm commented Jul 29, 2015

farodin91 commented Jul 29, 2015

Ms2ger commented Oct 6, 2015

larsbergstrom commented Jan 26, 2016

tschneidereit commented Jan 26, 2016

larsbergstrom commented May 12, 2016

nox commented May 12, 2016

jdm commented Jun 21, 2016

jdm commented Jun 21, 2016

jdm commented Jun 28, 2016

servo / servo

Join GitHub today

Implement Promise in Servo #4282

Implement Promise in Servo #4282

Comments

tetsuharuohzeki commented Dec 8, 2014

farodin91 commented Jul 29, 2015

jdm commented Jul 29, 2015

farodin91 commented Jul 29, 2015

Ms2ger commented Oct 6, 2015

larsbergstrom commented Jan 26, 2016

tschneidereit commented Jan 26, 2016

larsbergstrom commented May 12, 2016

nox commented May 12, 2016

jdm commented Jun 21, 2016

jdm commented Jun 21, 2016

jdm commented Jun 28, 2016