Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make <textarea> respect cols and rows HTML attributes #4291

Closed
jdm opened this issue Dec 8, 2014 · 1 comment
Closed

Make <textarea> respect cols and rows HTML attributes #4291

jdm opened this issue Dec 8, 2014 · 1 comment
Labels
A-content/css A-content/dom C-assigned E-less easy I-wrong

Comments

@jdm
Copy link
Member

@jdm jdm commented Dec 8, 2014

This can be modeled after the way that the size attributed is implemented for <input> elements. See components/style/legacy.rs, and uses of SizeIntegerAttribute throughout the code: http://mxr.mozilla.org/servo/search?string=sizeintegerattribute
@mttr
Copy link
Contributor

@mttr mttr commented Dec 12, 2014

I'll take this one.
@jdm jdm added the C-assigned label Dec 12, 2014
@mttr mttr mentioned this issue Dec 15, 2014
Closed
bors-servo pushed a commit that referenced this issue Dec 15, 2014
bors-servo
auto merge of #4380 : mttr/servo/textarea_rows_and_cols, r=pcwalton
Loading status checks…
ef90fdc 
...with a bit of a caveat: sizing has the same problem as seen in #4378, and it is _significantly_ more noticeable when using `rows`.

Fixes #4291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/css A-content/dom C-assigned E-less easy I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Makes layout respect <textarea> rows and cols attributes
2 participants
@jdm @mttr
You can’t perform that action at this time.