Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SpiderMonkey #4338

Closed
jdm opened this issue Dec 11, 2014 · 0 comments
Closed

Upgrade SpiderMonkey #4338

jdm opened this issue Dec 11, 2014 · 0 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Dec 11, 2014

The current attempt is sitting in #3527.

Blockers:

  • Vec<Rooted<T>> replacement (#4334)
  • Vec<Temporary<T>> replacement (#4335)
  • Equivalent of MutNullableJS for primitives (#4337)
  • Lints to ban further uses of all of the above (#4336)
  • Replace the assertion during tracing DOM objects with an actual rootable object pointer
  • Rebase
  • Ensure review comments in https://critic.hoppipolla.co.uk/r/2730 are addressed.
  • Redesign Temporary<T> and Root<T> integration by duplicating SM's side tables, rather than storing pointers to Rust objects in them.
  • Add an FFI indirection layer (similar to jsglue.cpp) that calls the non-extern "C" methods in jsapi.h, avoiding the need to modify the header.

Nice to have:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.