Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window.performance.now() #4381

Closed
wants to merge 1 commit into from

Conversation

Manishearth
Copy link
Member

No description provided.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/3506

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm jdm added the S-needs-squash Some (or all) of the commits in the PR should be combined. label Dec 15, 2014
@jdm
Copy link
Member

jdm commented Dec 15, 2014

Looks good!

@mbrubeck
Copy link
Contributor

dom/performance.rs:53:9: 53:78 error: mismatched types: expected `f64`, found `u64` (expected f64, found u64)
dom/performance.rs:53         (time::precise_time_ns() - navStart) * 1000000 as DOMHighResTimeStamp
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dom/window.rs:385:39: 385:62 error: mismatched types: expected `f64`, found `u64` (expected f64, found u64)
dom/window.rs:385             navigation_start_precise: time::precise_time_ns(),

@mbrubeck mbrubeck added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-needs-squash Some (or all) of the commits in the PR should be combined. labels Dec 16, 2014
@bors-servo bors-servo closed this Dec 16, 2014
@Manishearth Manishearth deleted the performancenow branch September 3, 2015 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-code-changes Changes have not yet been made that were requested by a reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants