Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete border implementation #444

Closed
brson opened this issue May 14, 2013 · 0 comments
Closed

Complete border implementation #444

brson opened this issue May 14, 2013 · 0 comments

Comments

@brson
Copy link
Contributor

@brson brson commented May 14, 2013

http://www.w3.org/TR/CSS2/box.html#border-properties

Including:

  • all four sides can be styled independently
  • all styles rendered distinctly
  • all possible units interpreted correctly, including em and pt
@brson brson closed this May 14, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
@jgraham
Merge pull request servo#444 from zcorpan/zcorpan/resolve-urls
9c9f751 
Tests for HTML's resolve URLs
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
@bors-servo
Auto merge of servo#444 - kvark:clip_shared, r=glennw
dff3e5d 
Shared clip source for the shaders

This will make it easier to introduce clipped primitives outside of the currently supported rectangles and images (related to servo#405). Also includes servo#443

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/444)
<!-- Reviewable:end -->
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
@emilio
Bring the border radius back on Linux.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
c411ead 
I just noticed while reading over servo#444 that this same line is commented for
clipping. This was making the alpha component of the border radius being always
zero.

This brings back the border radius on Linux. I didn't notice any other issue.
Not totally sure why this only happens on Intel cards though, probably is a
floating point math issue?
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
@bors-servo
Auto merge of servo#446 - emilio:intel-linux, r=glennw
cb204bf 
Bring the border radius back on Linux.

I just noticed while reading over servo#444 that this same line is commented for
clipping. This was making the alpha component of the border radius being always
zero.

This brings back the border radius on Linux. I didn't notice any other issue.
Not totally sure why this only happens on Intel cards though, probably is a
floating point math issue?

Also, this improves the appearance with `LIBGL_ALWAYS_SOFTWARE=1` too, which I guess is the canonical representation.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/446)
<!-- Reviewable:end -->
@jdm jdm mentioned this issue Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@brson
You can’t perform that action at this time.